You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2016/12/13 22:31:52 UTC

Review Request 54721: Add common log rotation settings to YARN configs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54721/
-----------------------------------------------------------

Review request for Ambari, Andrii Voloshyn and Sumit Mohanty.


Bugs: AMBARI-19193
    https://issues.apache.org/jira/browse/AMBARI-19193


Repository: ambari


Description
-------

Add common log rotation settings to YARN configs


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 4a5ee25 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml 9ac34f3 

Diff: https://reviews.apache.org/r/54721/diff/


Testing
-------

1. Check if the parameters are exposed in UI and you can change it
2. Check if changed parameter values are reflected in DB - select config_data from clusterconfig where type_name = 'yarn-log4j' and version=2;
3. Check if changed param values are reflected in API - http://<ambari-server>:8080/api/v1/clusters/<clustername>/configurations?type=hadoop-env&tag=version1
4. Check if changed param values are reflected in files - queen /etc/hadoop/conf/log4j.properties log4j.appender.RMSUMMARY.MaxBackupIndex=15


Thanks,

Madhuvanthi Radhakrishnan


Re: Review Request 54721: Add common log rotation settings to YARN configs

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54721/#review159066
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On Dec. 13, 2016, 10:31 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54721/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 10:31 p.m.)
> 
> 
> Review request for Ambari, Andrii Voloshyn and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19193
>     https://issues.apache.org/jira/browse/AMBARI-19193
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add common log rotation settings to YARN configs
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 4a5ee25 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml 9ac34f3 
> 
> Diff: https://reviews.apache.org/r/54721/diff/
> 
> 
> Testing
> -------
> 
> 1. Check if the parameters are exposed in UI and you can change it
> 2. Check if changed parameter values are reflected in DB - select config_data from clusterconfig where type_name = 'yarn-log4j' and version=2;
> 3. Check if changed param values are reflected in API - http://<ambari-server>:8080/api/v1/clusters/<clustername>/configurations?type=hadoop-env&tag=version1
> 4. Check if changed param values are reflected in files - queen /etc/hadoop/conf/log4j.properties log4j.appender.RMSUMMARY.MaxBackupIndex=15
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>