You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/09/12 16:45:10 UTC

[GitHub] [arrow] mapleFU commented on a diff in pull request #37526: GH-35627: [Format][Integration] Add string-view to arrow format

mapleFU commented on code in PR #37526:
URL: https://github.com/apache/arrow/pull/37526#discussion_r1323311805


##########
format/Message.fbs:
##########
@@ -99,6 +99,14 @@ table RecordBatch {
 
   /// Optional compression of the message body
   compression: BodyCompression;
+
+  /// Some types such as Utf8View are represented using a variable number of buffers.
+  /// For each such Field in the pre-ordered flattened logical schema, there will be

Review Comment:
   Just want to make sure I'm understand, for:
   
   ```
   struct<i:int32, bv:BinaryView, uv: Utf8View>
   ```
   
   If bv has 2 "Variadic Buffer"s, uv has 1 "Variadic Buffer", how would be `variadicBufferCounts` be? `[2, 1]` or `[0, 2, 1]`?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org