You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Simone Gianni (JIRA)" <ji...@apache.org> on 2006/04/05 13:33:47 UTC

[jira] Created: (COCOON-1822) MultiValueField list-type="double-listbox" does not work correctly in ajax enabled forms

MultiValueField list-type="double-listbox" does not work correctly in ajax enabled forms
----------------------------------------------------------------------------------------

         Key: COCOON-1822
         URL: http://issues.apache.org/jira/browse/COCOON-1822
     Project: Cocoon
        Type: Bug

  Components: Blocks: Forms  
    Versions: 2.1.9-dev (current SVN)    
    Reporter: Simone Gianni
    Priority: Critical


The multi value field with fi:styling list-type="double-listbox" relies on forms_onsubmitHandlers to select all items in the right selection list before submitting. In an ajax form, it seems like forms_onsubmit is not installed on the form, so handlers are not called; in forms-field-styling.xsl this is clearly stated :

      <xsl:choose>
        <xsl:when test="@ajax = 'true'">
          <xsl:attribute name="dojoType">CFormsForm</xsl:attribute>
          <xsl:if test="@ajax = 'true'">
            <script type="text/javascript">cocoon.forms.ajax = true;</script>
          </xsl:if>
        </xsl:when>
        <xsl:otherwise>
          <xsl:attribute name="onsubmit">forms_onsubmit(); <xsl:value-of select="@onsubmit"/></xsl:attribute>
        </xsl:otherwise>
      </xsl:choose>

I don't think installing forms_onsubmit() also on ajax forma is a wise solution, but maybe we should call it from inside the ajax code, or at least check and execute onsubmit_handlers. If not, also the free-form multivalue field editor will not work correctly.

What's the best way to fix this issue?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1822) MultiValueField list-type="double-listbox" does not work correctly in ajax enabled forms

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612678#action_12612678 ] 

Antonio Gallardo commented on COCOON-1822:
------------------------------------------

Patch applied to 2.1.12-dev.

> MultiValueField list-type="double-listbox" does not work correctly in ajax enabled forms
> ----------------------------------------------------------------------------------------
>
>                 Key: COCOON-1822
>                 URL: https://issues.apache.org/jira/browse/COCOON-1822
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.9
>            Reporter: Simone Gianni
>            Assignee: Antonio Gallardo
>            Priority: Critical
>         Attachments: dojo-doublelist_patch.tar.gz
>
>
> The multi value field with fi:styling list-type="double-listbox" relies on forms_onsubmitHandlers to select all items in the right selection list before submitting. In an ajax form, it seems like forms_onsubmit is not installed on the form, so handlers are not called; in forms-field-styling.xsl this is clearly stated :
>       <xsl:choose>
>         <xsl:when test="@ajax = 'true'">
>           <xsl:attribute name="dojoType">CFormsForm</xsl:attribute>
>           <xsl:if test="@ajax = 'true'">
>             <script type="text/javascript">cocoon.forms.ajax = true;</script>
>           </xsl:if>
>         </xsl:when>
>         <xsl:otherwise>
>           <xsl:attribute name="onsubmit">forms_onsubmit(); <xsl:value-of select="@onsubmit"/></xsl:attribute>
>         </xsl:otherwise>
>       </xsl:choose>
> I don't think installing forms_onsubmit() also on ajax forma is a wise solution, but maybe we should call it from inside the ajax code, or at least check and execute onsubmit_handlers. If not, also the free-form multivalue field editor will not work correctly.
> What's the best way to fix this issue?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-1822) MultiValueField list-type="double-listbox" does not work correctly in ajax enabled forms

Posted by "Felix Knecht (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht updated COCOON-1822:
---------------------------------

    Fix Version/s: 2.2-dev (Current SVN)
                   2.1.12-dev (Current SVN)

> MultiValueField list-type="double-listbox" does not work correctly in ajax enabled forms
> ----------------------------------------------------------------------------------------
>
>                 Key: COCOON-1822
>                 URL: https://issues.apache.org/jira/browse/COCOON-1822
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.9
>            Reporter: Simone Gianni
>            Assignee: Antonio Gallardo
>            Priority: Critical
>             Fix For: 2.1.12-dev (Current SVN), 2.2-dev (Current SVN)
>
>         Attachments: dojo-doublelist_patch.tar.gz
>
>
> The multi value field with fi:styling list-type="double-listbox" relies on forms_onsubmitHandlers to select all items in the right selection list before submitting. In an ajax form, it seems like forms_onsubmit is not installed on the form, so handlers are not called; in forms-field-styling.xsl this is clearly stated :
>       <xsl:choose>
>         <xsl:when test="@ajax = 'true'">
>           <xsl:attribute name="dojoType">CFormsForm</xsl:attribute>
>           <xsl:if test="@ajax = 'true'">
>             <script type="text/javascript">cocoon.forms.ajax = true;</script>
>           </xsl:if>
>         </xsl:when>
>         <xsl:otherwise>
>           <xsl:attribute name="onsubmit">forms_onsubmit(); <xsl:value-of select="@onsubmit"/></xsl:attribute>
>         </xsl:otherwise>
>       </xsl:choose>
> I don't think installing forms_onsubmit() also on ajax forma is a wise solution, but maybe we should call it from inside the ajax code, or at least check and execute onsubmit_handlers. If not, also the free-form multivalue field editor will not work correctly.
> What's the best way to fix this issue?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-1822) MultiValueField list-type="double-listbox" does not work correctly in ajax enabled forms

Posted by "Karen Torres (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karen Torres updated COCOON-1822:
---------------------------------

    Attachment: dojo-doublelist_patch.tar.gz

Dojo-fied version of the multivalue double list widget.

> MultiValueField list-type="double-listbox" does not work correctly in ajax enabled forms
> ----------------------------------------------------------------------------------------
>
>                 Key: COCOON-1822
>                 URL: https://issues.apache.org/jira/browse/COCOON-1822
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.9
>            Reporter: Simone Gianni
>            Priority: Critical
>         Attachments: dojo-doublelist_patch.tar.gz
>
>
> The multi value field with fi:styling list-type="double-listbox" relies on forms_onsubmitHandlers to select all items in the right selection list before submitting. In an ajax form, it seems like forms_onsubmit is not installed on the form, so handlers are not called; in forms-field-styling.xsl this is clearly stated :
>       <xsl:choose>
>         <xsl:when test="@ajax = 'true'">
>           <xsl:attribute name="dojoType">CFormsForm</xsl:attribute>
>           <xsl:if test="@ajax = 'true'">
>             <script type="text/javascript">cocoon.forms.ajax = true;</script>
>           </xsl:if>
>         </xsl:when>
>         <xsl:otherwise>
>           <xsl:attribute name="onsubmit">forms_onsubmit(); <xsl:value-of select="@onsubmit"/></xsl:attribute>
>         </xsl:otherwise>
>       </xsl:choose>
> I don't think installing forms_onsubmit() also on ajax forma is a wise solution, but maybe we should call it from inside the ajax code, or at least check and execute onsubmit_handlers. If not, also the free-form multivalue field editor will not work correctly.
> What's the best way to fix this issue?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COCOON-1822) MultiValueField list-type="double-listbox" does not work correctly in ajax enabled forms

Posted by "Felix Knecht (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617397#action_12617397 ] 

Felix Knecht commented on COCOON-1822:
--------------------------------------

Patch applied to cocoon-forms-impl 1.2.0-SNAPSHOT (cocoon-2.2)

> MultiValueField list-type="double-listbox" does not work correctly in ajax enabled forms
> ----------------------------------------------------------------------------------------
>
>                 Key: COCOON-1822
>                 URL: https://issues.apache.org/jira/browse/COCOON-1822
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.9
>            Reporter: Simone Gianni
>            Assignee: Antonio Gallardo
>            Priority: Critical
>         Attachments: dojo-doublelist_patch.tar.gz
>
>
> The multi value field with fi:styling list-type="double-listbox" relies on forms_onsubmitHandlers to select all items in the right selection list before submitting. In an ajax form, it seems like forms_onsubmit is not installed on the form, so handlers are not called; in forms-field-styling.xsl this is clearly stated :
>       <xsl:choose>
>         <xsl:when test="@ajax = 'true'">
>           <xsl:attribute name="dojoType">CFormsForm</xsl:attribute>
>           <xsl:if test="@ajax = 'true'">
>             <script type="text/javascript">cocoon.forms.ajax = true;</script>
>           </xsl:if>
>         </xsl:when>
>         <xsl:otherwise>
>           <xsl:attribute name="onsubmit">forms_onsubmit(); <xsl:value-of select="@onsubmit"/></xsl:attribute>
>         </xsl:otherwise>
>       </xsl:choose>
> I don't think installing forms_onsubmit() also on ajax forma is a wise solution, but maybe we should call it from inside the ajax code, or at least check and execute onsubmit_handlers. If not, also the free-form multivalue field editor will not work correctly.
> What's the best way to fix this issue?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (COCOON-1822) MultiValueField list-type="double-listbox" does not work correctly in ajax enabled forms

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Gallardo reassigned COCOON-1822:
----------------------------------------

    Assignee: Antonio Gallardo

> MultiValueField list-type="double-listbox" does not work correctly in ajax enabled forms
> ----------------------------------------------------------------------------------------
>
>                 Key: COCOON-1822
>                 URL: https://issues.apache.org/jira/browse/COCOON-1822
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.9
>            Reporter: Simone Gianni
>            Assignee: Antonio Gallardo
>            Priority: Critical
>         Attachments: dojo-doublelist_patch.tar.gz
>
>
> The multi value field with fi:styling list-type="double-listbox" relies on forms_onsubmitHandlers to select all items in the right selection list before submitting. In an ajax form, it seems like forms_onsubmit is not installed on the form, so handlers are not called; in forms-field-styling.xsl this is clearly stated :
>       <xsl:choose>
>         <xsl:when test="@ajax = 'true'">
>           <xsl:attribute name="dojoType">CFormsForm</xsl:attribute>
>           <xsl:if test="@ajax = 'true'">
>             <script type="text/javascript">cocoon.forms.ajax = true;</script>
>           </xsl:if>
>         </xsl:when>
>         <xsl:otherwise>
>           <xsl:attribute name="onsubmit">forms_onsubmit(); <xsl:value-of select="@onsubmit"/></xsl:attribute>
>         </xsl:otherwise>
>       </xsl:choose>
> I don't think installing forms_onsubmit() also on ajax forma is a wise solution, but maybe we should call it from inside the ajax code, or at least check and execute onsubmit_handlers. If not, also the free-form multivalue field editor will not work correctly.
> What's the best way to fix this issue?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.