[GitHub] [flink] MartijnVisser commented on a change in pull request #18577: [FLINK-25880][Docs] Implement Matomo in Flink documentation

[GitBox <gi...@apache.org>]

MartijnVisser commented on a change in pull request #18577:
URL: https://github.com/apache/flink/pull/18577#discussion_r796400729



##########
File path: docs/layouts/_default/baseof.html
##########
@@ -23,6 +23,25 @@
   {{ hugo.Generator }}
   {{ partial "docs/html-head" . }}
   {{ partial "docs/inject/head" . }}
+    <!-- Matomo -->
+    <script>
+      var _paq = window._paq = window._paq || [];
+      /* tracker methods like "setCustomDimension" should be called before "trackPageView" */
+      /* We explicitly disable cookie tracking to avoid privacy issues */
+      _paq.push(['disableCookies']);
+      /* Measure a visit to flink.apache.org and nightlies.apache.org/flink as the same visit */
+      _paq.push(["setDomains", ["*.flink.apache.org","*.nightlies.apache.org/flink"]]);

Review comment:
       The documentation is, but the project website isn't. By setting this value, we make sure that when a visit is starting at flink.apache.org and then clicks on documentation (and vice versa) is tracked as the same visit and not starting a new one. Else each click would appear as an 'outlink' like the user left our website, which isn't the case. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org