[GitHub] [trafficserver] shinrich commented on a change in pull request #7479: Origin session reuse

[GitBox <gi...@apache.org>]

shinrich commented on a change in pull request #7479:
URL: https://github.com/apache/trafficserver/pull/7479#discussion_r576402549



##########
File path: iocore/net/SSLSessionCache.h
##########
@@ -198,3 +201,19 @@ class SSLSessionCache
   SSLSessionBucket *session_bucket = nullptr;
   size_t nbuckets;
 };
+
+class SSLOriginSessionCache
+{
+public:
+  SSLOriginSessionCache();
+  ~SSLOriginSessionCache();
+
+  void insertSession(std::string lookup_key, SSL_SESSION *sess);
+  SSL_SESSION *getSession(std::string lookup_key);
+
+private:
+  mutable std::shared_mutex mutex;

Review comment:
       For our architectures, pthread_mutex and std::shared_mutex should be equivalent, but moving forward std::shared_mutex should give us better portability and ability to pick up new mutex technology as it becomes available.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org