You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Kay Kay (JIRA)" <ji...@apache.org> on 2010/02/10 22:21:28 UTC
[jira] Created: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
s/StringBuffer/StringBuilder - as necessary
-------------------------------------------
Key: HDFS-968
URL: https://issues.apache.org/jira/browse/HDFS-968
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: Kay Kay
Attachments: HDFS-968.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833717#action_12833717 ]
Hadoop QA commented on HDFS-968:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12435491/HDFS-968.patch
against trunk revision 908628.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/229/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/229/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/229/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/229/console
This message is automatically generated.
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853879#action_12853879 ]
Hudson commented on HDFS-968:
-----------------------------
Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #302 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/302/])
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 0.22.0
>
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HDFS-968:
-------------------------
Status: Patch Available (was: Open)
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834939#action_12834939 ]
Suresh Srinivas commented on HDFS-968:
--------------------------------------
+1 for the patch.
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833950#action_12833950 ]
Kay Kay commented on HDFS-968:
------------------------------
Test failed with -
org.apache.hadoop.hdfs.security.TestDelegationToken.testDelegationTokenWithRealUser (from TestDelegationToken)
Error Message
User: RealUser is not allowed to impersonate proxyUser
Stacktrace
org.apache.hadoop.ipc.RemoteException: User: RealUser is not allowed to impersonate proxyUser
at org.apache.hadoop.ipc.Client.call(Client.java:887)
at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:198)
at $Proxy7.getProtocolVersion(Unknown Source)
at org.apache.hadoop.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:228)
at org.apache.hadoop.ipc.RPC.getProxy(RPC.java:220)
at org.apache.hadoop.hdfs.DFSClient.createRPCNamenode(DFSClient.java:151)
at org.apache.hadoop.hdfs.DFSClient.<init>(DFSClient.java:250)
at org.apache.hadoop.hdfs.DFSClient.<init>(DFSClient.java:217)
at org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:87)
at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:1747)
at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:69)
at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:1775)
at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:1763)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:193)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:101)
at org.apache.hadoop.hdfs.MiniDFSCluster.getFileSystem(MiniDFSCluster.java:813)
at org.apache.hadoop.hdfs.security.TestDelegationToken$1.run(TestDelegationToken.java:147)
at org.apache.hadoop.hdfs.security.TestDelegationToken$1.run(TestDelegationToken.java:145)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:396)
at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:706)
at org.apache.hadoop.hdfs.security.TestDelegationToken.testDelegationTokenWithRealUser(TestDelegationToken.java:144)
I don't think it has anything to do with this patch though.
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845586#action_12845586 ]
Hudson commented on HDFS-968:
-----------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #215 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/215/])
. Use StringBuilder instead of StringBuffer for better performance. Contributed by Kay Kay.
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 0.22.0
>
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HDFS-968:
-------------------------
Status: Open (was: Patch Available)
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HDFS-968:
-------------------------
Attachment: HDFS-968.patch
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833787#action_12833787 ]
Hadoop QA commented on HDFS-968:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12435491/HDFS-968.patch
against trunk revision 908628.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/116/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/116/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/116/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/116/console
This message is automatically generated.
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853972#action_12853972 ]
Hudson commented on HDFS-968:
-----------------------------
Integrated in Hadoop-Hdfs-trunk #275 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/])
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 0.22.0
>
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HDFS-968:
-------------------------
Status: Patch Available (was: Open)
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853672#action_12853672 ]
Hudson commented on HDFS-968:
-----------------------------
Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #146 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/146/])
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 0.22.0
>
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835034#action_12835034 ]
Kay Kay commented on HDFS-968:
------------------------------
Thanks. If so, would be nice to get this committed before this gets out of sync with the tree.
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-968) s/StringBuffer/StringBuilder - as
necessary
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-968:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Assignee: Kay Kay
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I committed the patch. Thanks you Kay Kay.
> s/StringBuffer/StringBuilder - as necessary
> -------------------------------------------
>
> Key: HDFS-968
> URL: https://issues.apache.org/jira/browse/HDFS-968
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 0.22.0
>
> Attachments: HDFS-968.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.