You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by mohammadshahidkhan <gi...@git.apache.org> on 2016/09/08 05:10:27 UTC
[GitHub] incubator-carbondata pull request #140: [CARBONDATA-227] In block distributi...
GitHub user mohammadshahidkhan opened a pull request:
https://github.com/apache/incubator-carbondata/pull/140
[CARBONDATA-227] In block distribution parralelism is decided initial\u2026
In block distribution parralelism is decided initially and not re initialized after requesting new executors. Due to this task per node initialization is getting wrong.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata parrallelism_Calculation_issue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #140
----
commit c1c49fcc0da754459b42911089d77f57219c8a81
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2016-09-08T05:07:49Z
[CARBONDATA-227] In block distribution parralelism is decided initially and not re initialized after requesting new executors. Due to this task per node initialization is getting wrong.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #140: [CARBONDATA-227] In block distributi...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/140#discussion_r77950753
--- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
@@ -73,7 +73,7 @@ class CarbonScanRDD[V: ClassTag](
baseStoreLocation: String)
extends RDD[V](sc, Nil) with Logging {
- val defaultParallelism = sc.defaultParallelism
+ var defaultParallelism = sc.defaultParallelism
--- End diff --
now member is not required, make it a private val.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #140: [CARBONDATA-227] In block distributi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #140: [CARBONDATA-227] In block distributi...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/140#discussion_r77950786
--- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
@@ -110,13 +110,15 @@ class CarbonScanRDD[V: ClassTag](
new BlockletInfos(inputSplit.getNumberOfBlocklets, 0, inputSplit.getNumberOfBlocklets)
)
)
+ val activeNodes = DistributionUtil
+ .ensureExecutorsAndGetNodeList(blockListTemp.toArray, sparkContext)
--- End diff --
can u test it on dynamic executors case and confirm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---