You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Kalyani Kashikar <ka...@freestoneinfotech.com> on 2016/06/02 07:32:22 UTC
Review Request 48163: ATLAS-848 : Atlas UI: Search term box in left
navigation is not auto refresh.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48163/
-----------------------------------------------------------
Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.
Bugs: ATLAS-848
https://issues.apache.org/jira/browse/ATLAS-848
Repository: atlas
Description
-------
New terms added in the login session does not appear in search auto-fill/results.
Diffs
-----
dashboardv2/public/js/views/business_catalog/BusinessCatalogLayoutView.js 66f870a
Diff: https://reviews.apache.org/r/48163/diff/
Testing
-------
Verified - After adding term search box is auto refresh.
Thanks,
Kalyani Kashikar
Re: Review Request 48163: ATLAS-848 : Atlas UI: Search term box in
left navigation is not auto refresh.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48163/#review136063
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On June 3, 2016, 8:42 a.m., Kalyani Kashikar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48163/
> -----------------------------------------------------------
>
> (Updated June 3, 2016, 8:42 a.m.)
>
>
> Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.
>
>
> Bugs: ATLAS-848
> https://issues.apache.org/jira/browse/ATLAS-848
>
>
> Repository: atlas
>
>
> Description
> -------
>
> New terms added in the login session does not appear in search auto-fill/results.
>
>
> Diffs
> -----
>
> dashboardv2/public/css/scss/form.scss f5f9672
> dashboardv2/public/js/templates/business_catalog/BusinessCatalogLayoutView_tmpl.html 844071d
> dashboardv2/public/js/views/business_catalog/BusinessCatalogLayoutView.js 66f870a
>
> Diff: https://reviews.apache.org/r/48163/diff/
>
>
> Testing
> -------
>
> Verified - After adding term search box is auto refresh.
>
>
> Thanks,
>
> Kalyani Kashikar
>
>
Re: Review Request 48163: ATLAS-848 : Atlas UI: Search term box in
left navigation is not auto refresh.
Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48163/
-----------------------------------------------------------
(Updated June 3, 2016, 8:42 a.m.)
Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.
Changes
-------
Added Refresh button for taxonomy and Search box.
Bugs: ATLAS-848
https://issues.apache.org/jira/browse/ATLAS-848
Repository: atlas
Description
-------
New terms added in the login session does not appear in search auto-fill/results.
Diffs (updated)
-----
dashboardv2/public/css/scss/form.scss f5f9672
dashboardv2/public/js/templates/business_catalog/BusinessCatalogLayoutView_tmpl.html 844071d
dashboardv2/public/js/views/business_catalog/BusinessCatalogLayoutView.js 66f870a
Diff: https://reviews.apache.org/r/48163/diff/
Testing
-------
Verified - After adding term search box is auto refresh.
Thanks,
Kalyani Kashikar
Re: Review Request 48163: ATLAS-848 : Atlas UI: Search term box in
left navigation is not auto refresh.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48163/#review135921
-----------------------------------------------------------
dashboardv2/public/js/views/business_catalog/BusinessCatalogLayoutView.js (line 351)
<https://reviews.apache.org/r/48163/#comment200934>
This fix handles only the terms added in the current browser session. Terms added by other browser sessions (and by API calls) are still not shown in search results or lookup.
How about adding a 'refresh' button in Taxonomy tab, which will recreate the taxonomy tree from the contents from server-side? This will enable users to see the latest contents; this can also be used to update lookup/search data. Please note that the updates made in the current browser session should not require users explicitly to refresh.
- Madhan Neethiraj
On June 2, 2016, 7:32 a.m., Kalyani Kashikar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48163/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 7:32 a.m.)
>
>
> Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.
>
>
> Bugs: ATLAS-848
> https://issues.apache.org/jira/browse/ATLAS-848
>
>
> Repository: atlas
>
>
> Description
> -------
>
> New terms added in the login session does not appear in search auto-fill/results.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/views/business_catalog/BusinessCatalogLayoutView.js 66f870a
>
> Diff: https://reviews.apache.org/r/48163/diff/
>
>
> Testing
> -------
>
> Verified - After adding term search box is auto refresh.
>
>
> Thanks,
>
> Kalyani Kashikar
>
>