[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #12561: fix(pie): pie series render incorrectly after editing its data in DataView. close #12560.

[GitBox <gi...@apache.org>]

Ovilia commented on a change in pull request #12561:
URL: https://github.com/apache/incubator-echarts/pull/12561#discussion_r420526638



##########
File path: src/component/toolbox/feature/DataView.js
##########
@@ -426,13 +432,17 @@ function tryMergeDataOption(newData, originalData) {
     return zrUtil.map(newData, function (newVal, idx) {
         var original = originalData && originalData[idx];
         if (zrUtil.isObject(original) && !zrUtil.isArray(original)) {
-            if (zrUtil.isObject(newVal) && !zrUtil.isArray(newVal)) {
-                newVal = newVal.value;
+            var _newVal;
+            if (zrUtil.isArray(newVal) || zrUtil.isObject(newVal)) {

Review comment:
       Thanks for your contribution.
   
   Could you explain the change here?
   
   And please do not use `_` in variable names.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org