You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2018/05/01 03:04:16 UTC

[GitHub] spark pull request #21153: [SPARK-24058][ML][PySpark] Default Params in ML s...

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21153#discussion_r185159691
  
    --- Diff: python/pyspark/util.py ---
    @@ -61,6 +62,26 @@ def _get_argspec(f):
         return argspec
     
     
    +def majorMinorVersion(version):
    --- End diff --
    
    > Also, shall we make this match the Scala API?
    Do you mean to throw exception when unable to parse Spark version?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org