[GitHub] keith-turner commented on issue #960: Use NewTableConfiguration (and also trivial code cleanup)

[GitBox <gi...@apache.org>]

keith-turner commented on issue #960: Use NewTableConfiguration (and also trivial code cleanup)
URL: https://github.com/apache/fluo/pull/960#issuecomment-340032022
 
 
   I was thinking of manually testing this changes, but then it occurred to me it would be nice to test the following in a IT
   
    * That locality groups are setup after init.  Test this by requesting loc groups using Accumulo public API.
    * That iterators were properly setup after init.  Test this by getting tablets iters using public API.  
   
   These test could possibly be done in FluoAdminImplIT.
   
   The reason I wanted to test manually is because I had angst about the copied code from Accumulo.  If iterators were not properly set, then other ITs would probably catch that.  However if loc groups were not properly set, nothing would catch that (it would just cause performance problems).  So I think checking loc gorups after init is a good test even w/o these changes.  These test could be done in this issue or a follow on issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services