You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by ji...@apache.org on 2016/07/05 23:15:47 UTC
[24/32] incubator-geode git commit: refactored isTombstoneNotNeeded
refactored isTombstoneNotNeeded
Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/161c80ff
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/161c80ff
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/161c80ff
Branch: refs/heads/feature/GEODE-1571
Commit: 161c80fffdf196996d9e8acd20789339ff9d2744
Parents: 83c4940
Author: Darrel Schneider <ds...@pivotal.io>
Authored: Tue Jun 21 16:31:18 2016 -0700
Committer: Darrel Schneider <ds...@pivotal.io>
Committed: Tue Jul 5 14:30:09 2016 -0700
----------------------------------------------------------------------
.../internal/cache/AbstractRegionMap.java | 24 ++++++++++++++------
1 file changed, 17 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/161c80ff/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java b/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
index bc919fc..0c906d9 100644
--- a/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
+++ b/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
@@ -3637,21 +3637,31 @@ public abstract class AbstractRegionMap implements RegionMap {
public boolean isTombstoneNotNeeded(RegionEntry re, int destroyedVersion) {
// no need for synchronization - stale values are okay here
- RegionEntry actualRe = getEntry(re.getKey());
// TODO this looks like a problem for regionEntry pooling
- if (actualRe != re) { // null actualRe is okay here
- return true; // tombstone was evicted at some point
+ if ( getEntry(re.getKey()) != re) {
+ // region entry was either removed (null)
+ // or changed to a different region entry.
+ // In either case the old tombstone is no longer needed.
+ return true;
+ }
+ if (!re.isTombstone()) {
+ // if the region entry no longer contains a tombstone
+ // then the old tombstone is no longer needed
+ return true;
}
- VersionStamp vs = re.getVersionStamp();
+ VersionStamp<?> vs = re.getVersionStamp();
if (vs == null) {
// if we have no VersionStamp why were we even added as a tombstone?
// We used to see an NPE here. See bug 52092.
logger.error("Unexpected RegionEntry scheduled as tombstone: re.getClass {} destroyedVersion {}", re.getClass(), destroyedVersion);
return true;
}
- int entryVersion = vs.getEntryVersion();
- boolean isSameTombstone = (entryVersion == destroyedVersion && re.isTombstone());
- return !isSameTombstone;
+ if (vs.getEntryVersion() != destroyedVersion) {
+ // the version changed so old tombstone no longer needed
+ return true;
+ }
+ // region entry still has the same tombstone so we need to keep it.
+ return false;
}
/** removes a tombstone that has expired locally */