You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/09/27 07:59:41 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #43139: [SPARK-45350][CORE] Rename the imported `java.lang.Boolean` to JBoolean

HyukjinKwon commented on code in PR #43139:
URL: https://github.com/apache/spark/pull/43139#discussion_r1338202291


##########
core/src/main/scala/org/apache/spark/deploy/rest/SubmitRestProtocolResponse.scala:
##########
@@ -17,14 +17,14 @@
 
 package org.apache.spark.deploy.rest
 
-import java.lang.Boolean
+import java.lang.{Boolean => JBoolean}

Review Comment:
   I think this is fine. We have different practice too, e.g., in sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org