[jira] [Commented] (MAPREDUCE-4092) commitJob Exception does not fail job (regression in 0.23 vs 0.20)

["Robert Joseph Evans (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244263#comment-13244263 ] 

Robert Joseph Evans commented on MAPREDUCE-4092:
------------------------------------------------

The patch looks good to me.  The only one minor issue I have is that in checkJobCompleteSuccess we are still logging at a warn, but we are failing the job, so I would expect that to be logged at an error instead.  I can fix that when I check it in +1

The test failures look to be caused by a runaway process.
                
> commitJob Exception does not fail job (regression in 0.23 vs 0.20)
> ------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4092
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.2
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>            Priority: Blocker
>         Attachments: MAPREDUCE-4092.patch, MAPREDUCE-4092.patch
>
>
> If commitJob throws an exception JobImpl will swallow the exception with a warning and succeed the Job. This is a break from 0.20 and 1.0 where commitJob exception will fail the job
> Exception logged in the AM as WARN
>   org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl: Could not do commit for Job
> Job still finishes as succeeded

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira