You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "amartins23 (via GitHub)" <gi...@apache.org> on 2023/06/21 11:40:05 UTC

[GitHub] [arrow-rs] amartins23 opened a new issue, #4439: Allow implementations of `FlightSqlService` to handle custom actions and commands

amartins23 opened a new issue, #4439:
URL: https://github.com/apache/arrow-rs/issues/4439

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   
   The current `FlightSqlService` trait allows the implementer to handle custom commands in the `DoGet` call via `do_get_fallback` method implementation. However, no such possibility is offered for `DoPut`, `DoAction` and `ListActions`.
   
   A similar case could be made for `DoExchange`.
   
   **Describe the solution you'd like**
   
   Create new methods (with default implementations) in the `FlightSqlService` trait: `do_put_fallback`, `do_action_fallback`, with equivalent behavior as the `do_get_fallback` method. Furthermore, add a method that enables the implementation of the `FlightSqlService` trait to fill in additional actions to the actions returned by `ListActions` (https://github.com/apache/arrow-rs/blob/0bcf200ce22bd9a767dbe4c0fefcda6176e66f6e/arrow-flight/src/sql/server.rs#L608-L617), maybe named `add_custom_actions` that adds the actions to the existing vector, or a `list_custom_actions` that returns a (optional) vector that is appended to the existing vector.
   
   **Describe alternatives you've considered**
   
   The alternative is to create a wrapper `FlightService` implementation that has custom handling, then forwards everything to the existing implementation provided by implementing `FlightSqlService`.
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold closed issue #4439: [FlightSQL] Allow implementations of `FlightSqlService` to handle custom actions and commands

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #4439: [FlightSQL] Allow implementations of `FlightSqlService` to handle custom actions and commands
URL: https://github.com/apache/arrow-rs/issues/4439


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org