You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/07/24 15:46:13 UTC
[GitHub] [maven-plugin-tools] slawekjaranowski opened a new pull request, #125: [MPLUGIN-412] Use Maven core artifacts in provided scope
slawekjaranowski opened a new pull request, #125:
URL: https://github.com/apache/maven-plugin-tools/pull/125
in production and in IT tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski merged pull request #125: [MPLUGIN-412] Use Maven core artifacts in provided scope
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #125:
URL: https://github.com/apache/maven-plugin-tools/pull/125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #125: [MPLUGIN-412] Use Maven core artifacts in provided scope
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #125:
URL: https://github.com/apache/maven-plugin-tools/pull/125#discussion_r928300887
##########
maven-plugin-plugin/src/it/annotation-with-inheritance-from-deps/pom.xml:
##########
@@ -43,31 +43,33 @@ under the License.
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>@mavenVersion@</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-core</artifactId>
+ <version>@mavenVersion@</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.plugin-tools</groupId>
<artifactId>maven-plugin-annotations</artifactId>
<version>@project.version@</version>
- <scope>compile</scope>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.plugin-tools</groupId>
<artifactId>maven-plugin-tools-annotations</artifactId>
<version>@project.version@</version>
<classifier>tests</classifier>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
Review Comment:
comments added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on a diff in pull request #125: [MPLUGIN-412] Use Maven core artifacts in provided scope
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #125:
URL: https://github.com/apache/maven-plugin-tools/pull/125#discussion_r928281389
##########
maven-plugin-plugin/src/it/mplugin-272_java8/pom.xml:
##########
@@ -32,11 +32,13 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>@mavenVersion@</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.plugin-tools</groupId>
<artifactId>maven-plugin-annotations</artifactId>
<version>@project.version@</version>
+ <scope>provided</scope>
</dependency>
</dependencies>
Review Comment:
I can see that this file uses a 4-space indent instead of 2.
##########
maven-plugin-plugin/src/it/annotation-with-inheritance-from-deps/pom.xml:
##########
@@ -43,31 +43,33 @@ under the License.
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>@mavenVersion@</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-core</artifactId>
+ <version>@mavenVersion@</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.plugin-tools</groupId>
<artifactId>maven-plugin-annotations</artifactId>
<version>@project.version@</version>
- <scope>compile</scope>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.plugin-tools</groupId>
<artifactId>maven-plugin-tools-annotations</artifactId>
<version>@project.version@</version>
<classifier>tests</classifier>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
Review Comment:
This deserves a comment, no? At least on the commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org