You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/14 09:15:51 UTC
[GitHub] [incubator-dolphinscheduler] kezhenxu94 opened a new pull request #4453: chore: set up license-eye to check license headers
kezhenxu94 opened a new pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453
## What is the purpose of the pull request
This PR sets up license-eye to check the license headers, and add review comments when there are files missing license header.
## Brief change log
`.github/workflows/*.yml`:
- Set up license-eye to check license headers.
- Use built-in feature to checkout submodules instead of manually checking out.
## Verify this pull request
- [x] This pull request is code cleanup without any test coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#issuecomment-760587491
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4453&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4453&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4453&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4453&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4453&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4453&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4453&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4453&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4453&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4453&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4453&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4453&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4453&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4453&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4453&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#issuecomment-760586334
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4453?src=pr&el=h1) Report
> Merging [#4453](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4453?src=pr&el=desc) (1e61ce1) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/b6ce3cfdf0cd4206028072bac9a00a9272e6e79f?el=desc) (b6ce3cf) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4453?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4453 +/- ##
============================================
- Coverage 43.35% 43.32% -0.04%
+ Complexity 3196 3192 -4
============================================
Files 471 471
Lines 21834 21834
Branches 2648 2648
============================================
- Hits 9466 9459 -7
- Misses 11464 11471 +7
Partials 904 904
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4453?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4453/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | `3.00% <0.00%> (-1.00%)` | |
| [...inscheduler/service/zk/CuratorZookeeperClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4453/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQ3VyYXRvclpvb2tlZXBlckNsaWVudC5qYXZh) | `60.97% <0.00%> (-4.88%)` | `7.00% <0.00%> (-1.00%)` | |
| [...org/apache/dolphinscheduler/remote/utils/Host.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4453/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0hvc3QuamF2YQ==) | `13.43% <0.00%> (-2.99%)` | `5.00% <0.00%> (-1.00%)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4453/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `51.38% <0.00%> (-1.39%)` | `10.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4453?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4453?src=pr&el=footer). Last update [b6ce3cf...1e61ce1](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4453?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] kezhenxu94 commented on pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#issuecomment-760120660
> @kezhenxu94 Maybe you should pass the unit test at first.
Check the changed files, I didn't touch the codes, the test case itself is flaky. Rerunning may help but I don't have access right to rerun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#discussion_r557817027
##########
File path: pom.xml
##########
@@ -924,49 +923,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.apache.rat</groupId>
- <artifactId>apache-rat-plugin</artifactId>
- <version>${apache.rat.version}</version>
- <configuration>
- <excludeSubProjects>false</excludeSubProjects>
- <addDefaultLicenseMatchers>false</addDefaultLicenseMatchers>
- <licenses>
- <license implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">
- <licenseFamilyCategory>AL20</licenseFamilyCategory>
- <licenseFamilyName>Apache License, 2.0</licenseFamilyName>
- <patterns>
- <pattern>Licensed to the Apache Software Foundation (ASF)</pattern>
- </patterns>
- </license>
- </licenses>
- <licenseFamilies>
- <licenseFamily implementation="org.apache.rat.license.SimpleLicenseFamily">
- <familyName>Apache License, 2.0</familyName>
- </licenseFamily>
- </licenseFamilies>
- <excludes>
- <exclude>**/node_modules/**</exclude>
- <exclude>**/node/**</exclude>
- <exclude>**/dist/**</exclude>
- <exclude>**/licenses/**</exclude>
- <exclude>.github/**</exclude>
- <exclude>**/sql/soft_version</exclude>
- <exclude>**/common/utils/ScriptRunner.java</exclude>
- <exclude>**/*.json</exclude>
- <!-- document files -->
- <exclude>**/*.md</exclude>
- <excldue>**/*.MD</excldue>
- <exclude>**/*.txt</exclude>
- <exclude>**/docs/**</exclude>
- <exclude>**/*.babelrc</exclude>
- <exclude>**/*.eslint*</exclude>
- <exclude>**/.mvn/jvm.config</exclude>
- <exclude>**/.mvn/wrapper/**</exclude>
- </excludes>
- <consoleOutput>true</consoleOutput>
- </configuration>
- </plugin>
Review comment:
Would it be better to keep the rat plugin? It can help us to conduct self-checks more conveniently in the development environment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#issuecomment-760553946
> > @kezhenxu94 Maybe you should pass the unit test at first.
>
> Check the changed files, I didn't touch the codes, the test case itself is flaky. Rerunning may help but I don't have access right to rerun.
good job, I re-run the UT test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#discussion_r557820982
##########
File path: pom.xml
##########
@@ -924,49 +923,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.apache.rat</groupId>
- <artifactId>apache-rat-plugin</artifactId>
- <version>${apache.rat.version}</version>
- <configuration>
- <excludeSubProjects>false</excludeSubProjects>
- <addDefaultLicenseMatchers>false</addDefaultLicenseMatchers>
- <licenses>
- <license implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">
- <licenseFamilyCategory>AL20</licenseFamilyCategory>
- <licenseFamilyName>Apache License, 2.0</licenseFamilyName>
- <patterns>
- <pattern>Licensed to the Apache Software Foundation (ASF)</pattern>
- </patterns>
- </license>
- </licenses>
- <licenseFamilies>
- <licenseFamily implementation="org.apache.rat.license.SimpleLicenseFamily">
- <familyName>Apache License, 2.0</familyName>
- </licenseFamily>
- </licenseFamilies>
- <excludes>
- <exclude>**/node_modules/**</exclude>
- <exclude>**/node/**</exclude>
- <exclude>**/dist/**</exclude>
- <exclude>**/licenses/**</exclude>
- <exclude>.github/**</exclude>
- <exclude>**/sql/soft_version</exclude>
- <exclude>**/common/utils/ScriptRunner.java</exclude>
- <exclude>**/*.json</exclude>
- <!-- document files -->
- <exclude>**/*.md</exclude>
- <excldue>**/*.MD</excldue>
- <exclude>**/*.txt</exclude>
- <exclude>**/docs/**</exclude>
- <exclude>**/*.babelrc</exclude>
- <exclude>**/*.eslint*</exclude>
- <exclude>**/.mvn/jvm.config</exclude>
- <exclude>**/.mvn/wrapper/**</exclude>
- </excludes>
- <consoleOutput>true</consoleOutput>
- </configuration>
- </plugin>
Review comment:
Deeply thanks for your answers. You are right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] chengshiwen commented on pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#issuecomment-760115541
@kezhenxu94 Maybe you should pass the unit test at first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] kezhenxu94 commented on pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#issuecomment-760593534
@dailidong @CalvinKirs tests passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] kezhenxu94 commented on pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#issuecomment-760583118
> > Still failed.
>
> Can you try to update your code? I already fixed the UT error.
Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] kezhenxu94 commented on pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#issuecomment-760064812
@dailidong @lgcareer can you please take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#issuecomment-760577267
> Still failed.
Can you try to update your code? I already fixed the UT error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] kezhenxu94 commented on a change in pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#discussion_r557818938
##########
File path: pom.xml
##########
@@ -924,49 +923,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.apache.rat</groupId>
- <artifactId>apache-rat-plugin</artifactId>
- <version>${apache.rat.version}</version>
- <configuration>
- <excludeSubProjects>false</excludeSubProjects>
- <addDefaultLicenseMatchers>false</addDefaultLicenseMatchers>
- <licenses>
- <license implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">
- <licenseFamilyCategory>AL20</licenseFamilyCategory>
- <licenseFamilyName>Apache License, 2.0</licenseFamilyName>
- <patterns>
- <pattern>Licensed to the Apache Software Foundation (ASF)</pattern>
- </patterns>
- </license>
- </licenses>
- <licenseFamilies>
- <licenseFamily implementation="org.apache.rat.license.SimpleLicenseFamily">
- <familyName>Apache License, 2.0</familyName>
- </licenseFamily>
- </licenseFamilies>
- <excludes>
- <exclude>**/node_modules/**</exclude>
- <exclude>**/node/**</exclude>
- <exclude>**/dist/**</exclude>
- <exclude>**/licenses/**</exclude>
- <exclude>.github/**</exclude>
- <exclude>**/sql/soft_version</exclude>
- <exclude>**/common/utils/ScriptRunner.java</exclude>
- <exclude>**/*.json</exclude>
- <!-- document files -->
- <exclude>**/*.md</exclude>
- <excldue>**/*.MD</excldue>
- <exclude>**/*.txt</exclude>
- <exclude>**/docs/**</exclude>
- <exclude>**/*.babelrc</exclude>
- <exclude>**/*.eslint*</exclude>
- <exclude>**/.mvn/jvm.config</exclude>
- <exclude>**/.mvn/wrapper/**</exclude>
- </excludes>
- <consoleOutput>true</consoleOutput>
- </configuration>
- </plugin>
Review comment:
Self checking is convenient with license-eye via
```shell
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header check
```
and if you have files missing license headers, you can use
```
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
```
to add the headers automatically for you, which RAT plugin can't.
If you don't like using docker, you can still [download the binary](https://dist.apache.org/repos/dist/release/skywalking/eyes/0.1.0/skywalking-license-eye-0.1.0-bin.tgz) and run `license-eye header check/fix` to perform the checks/fixes.
However, if you want me to keep RAT plugin, I'm OK to do so, though I don't think it's necessary to keep it as license-eye has covered what RAT has
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] kezhenxu94 commented on pull request #4453: chore: set up license-eye to check license headers
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #4453:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4453#issuecomment-760571533
Still failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org