You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by frohwerk <gi...@git.apache.org> on 2018/11/13 21:29:55 UTC
[GitHub] activemq-artemis pull request #2429: Fix minor leak in FileMoveManagerTest
GitHub user frohwerk opened a pull request:
https://github.com/apache/activemq-artemis/pull/2429
Fix minor leak in FileMoveManagerTest
Not closing the InputStream makes this test flaky on Windows. The test breaks because [FileMoveManager::delete(java.io.File) Line 221](https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/files/FileMoveManager.java#L221) fails to delete the file if it's still "owned" by the JVM process on Windows.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/frohwerk/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2429.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2429
----
commit 4d0bc57c4088179b5954f3f5b6990819a0b2822b
Author: Andreas Frohwerk <an...@...>
Date: 2018-11-13T21:23:44Z
Fix minor leak in FileMoveManagerTest
Not closing the InputStream makes this test flaky on Windows. The test
breaks because FileMoveManager::delete(java.io.File) Line 221 fails
to delete the file if it's still "owned" by the JVM process on Windows.
----
---
[GitHub] activemq-artemis pull request #2429: Fix minor leak in FileMoveManagerTest
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2429
---