You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Darren Shepherd <da...@gmail.com> on 2013/09/13 17:06:09 UTC

Review Request 14126: Return name for getName() on LdapAuthenticator

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14126/
-----------------------------------------------------------

Review request for cloudstack and Donal Lafferty.


Repository: cloudstack-git


Description
-------

Currently getName() returns null, this patch just follows the style of the other authenticators in how they set and return their name.


Diffs
-----

  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java 559a979 

Diff: https://reviews.apache.org/r/14126/diff/


Testing
-------


Thanks,

Darren Shepherd

Re: Review Request 14126: Return name for getName() on LdapAuthenticator

Posted by Ian Duffy <ia...@ianduffy.ie>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14126/#review26081
-----------------------------------------------------------

Ship it!


Ship It!

- Ian Duffy


On Sept. 13, 2013, 3:06 p.m., Darren Shepherd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14126/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 3:06 p.m.)
> 
> 
> Review request for cloudstack and Donal Lafferty.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently getName() returns null, this patch just follows the style of the other authenticators in how they set and return their name.
> 
> 
> Diffs
> -----
> 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java 559a979 
> 
> Diff: https://reviews.apache.org/r/14126/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Darren Shepherd
> 
>