[GitHub] potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore
URL: https://github.com/apache/airflow/pull/4523#discussion_r249286255
 
 

 ##########
 File path: docs/howto/manage-connections.rst
 ##########
 @@ -70,10 +70,15 @@ When referencing the connection in the Airflow pipeline, the ``conn_id``
 should be the name of the variable without the prefix. For example, if the
 ``conn_id`` is named ``postgres_master`` the environment variable should be
 named ``AIRFLOW_CONN_POSTGRES_MASTER`` (note that the environment variable
-must be all uppercase). Airflow assumes the value returned from the
-environment variable to be in a URI format (e.g.
-``postgres://user:password@localhost:5432/master`` or
-``s3://accesskey:secretkey@S3``).
+must be all uppercase).
+
+Airflow assumes the value returned from the environment variable to be in a URI
+format (e.g.``postgres://user:password@localhost:5432/master`` or
+``s3://accesskey:secretkey@S3``). The underscore character is not allowed
+in the scheme part of URI, so it must be changed to a minus characeter
 
 Review comment:
   I think in this context it's "hyphen" not "minus" 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services