[GitHub] [geode] sabbey37 commented on pull request #6325: GEODE-9155: change frequency of passive expiration

[GitBox <gi...@apache.org>]

sabbey37 commented on pull request #6325:
URL: https://github.com/apache/geode/pull/6325#issuecomment-821309723


   I've been thinking about the way we check out a branch in CI and apply the changes.  I think, rather than trying to edit the patch file manually, the smarter thing to do may be the following:
   1. Check out the same branch locally as the branch we check out in `execute_redis_tests.sh` (right now we do `git checkout origin/5.0`, but we should consider checking out a specific release tag vs. a branch, since that 5.0 branch is still being updated and changes to the tests might mess up our patch [lines might be different, etc.])
   2. Apply the existing patch file
   3. Make desired changes
   4. Generate a new patch file based on those changes 
   5. Replace the current patch file


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org