[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6200: KVM: Enable SSL if keystore exists

[GitBox <gi...@apache.org>]

weizhouapache commented on code in PR #6200:
URL: https://github.com/apache/cloudstack/pull/6200#discussion_r853140379


##########
agent/src/main/java/com/cloud/agent/AgentShell.java:
##########
@@ -397,6 +399,24 @@ public void init(String[] args) throws ConfigurationException {
         _backoff.configure("ConstantTimeBackoff", new HashMap<String, Object>());
     }
 
+    private void enableSSL() {
+        final File agentFile = PropertiesUtil.findConfigFile("agent.properties");
+        if (agentFile == null) {
+            s_logger.info("Failed to find agent.properties file");
+            return;
+        }
+        String keystorePass = getProperty(null, "keystore.passphrase");
+        if (StringUtils.isBlank(keystorePass)) {
+            return;
+        }

Review Comment:
   @DaanHoogland no, each keystore has non-empty passphrase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org