You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by je...@cloudbees.com on 2016/08/30 04:02:16 UTC
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1903
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1903/>
Jenkins build is back to stable : jclouds-karaf » jclouds :: Karaf :: Integration Tests #1917
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1917/>
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1916
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1916/>
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1915
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1915/>
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1914
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1914/>
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1913
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1913/>
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1912
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1912/>
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1911
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1911/>
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1910
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1910/>
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1909
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1909/>
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1908
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1908/>
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1907
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1907/>
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1906
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1906/>
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1905
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1905/>
Re: Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1904
Posted by Ignasi Barrera <na...@apache.org>.
PR and discussion here: https://github.com/google/gson/pull/916
On 30 August 2016 at 09:26, Ignasi Barrera <ig...@gmail.com> wrote:
> @demobox, please correct me if I'm wrong, as I'm not an OSGi expert at all.
>
> Hmmm It looks like in Gson 2.6 the OSGi bundle configuration was
> removed by accident [1] and the exports were restored in Gson 2.6.2
> [2]. However, if you look at the comments of the pull request, you'll
> see that the "com.google.gson.internal" is now excluded from the
> exports, breaking backwards compatibility, and breaking jclouds-karaf.
>
> The build after the gson upgrade complains about that package not
> being available for the jclouds-core bundle.
>
> A quick look in GitHub shows we're using it in just a few places [3],
> but I don't really know if we can get rid of those. Perhaps after
> upgrading to 2.7 there are alternative ways to achieve what the code
> that uses internal packages is doing now (but I don't think so).
>
>
> We have several options:
>
> * Downgrade to Gson 2.5, which is the last version that exports the
> gson internal packages.
> * Try to add the exports back (I'm preparing a PR and see where the
> discussion takes us).
> * Others?
>
> I.
>
>
> [1] https://github.com/google/gson/issues/796
> [2] https://github.com/google/gson/pull/797
> [3] https://github.com/jclouds/jclouds/search?utf8=%E2%9C%93&q=%22com.google.gson.internal%22&type=Code
>
> On 30 August 2016 at 08:47, Andrew Gaul <ga...@apache.org> wrote:
>> I cannot resolve this issue; reverting the suspect gson commit yields
>> similar but different errors on my development machine:
>>
>> ERROR: Bundle org.apache.sshd.core [26] Error starting mvn:org.apache.sshd/sshd-core/0.12.0 (org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sshd.core [26]: Unable to resolve 26.0: missing requirement [26.0] osgi.ee; (&(osgi.ee=JavaSE)(version=1.5)))
>> org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sshd.core [26]: Unable to resolve 26.0: missing requirement [26.0] osgi.ee; (&(osgi.ee=JavaSE)(version=1.5))
>>
>> Can anyone help me investigate this?
>>
>> On Tue, Aug 30, 2016 at 12:44:05AM -0400, jenkins-no-reply@cloudbees.com wrote:
>>> See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1904/>
>>>
>>
>> --
>> Andrew Gaul
>> http://gaul.org/
Re: Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1904
Posted by Ignasi Barrera <na...@apache.org>.
Ok, there is no hope for the fix to be merged in gson, so I'd suggest we
downgrade to version 2.5, which is the last one exporting those packages,
and open a jirs isssue to remove the uses of the gson internal packages.
Sounds good?
@gaul do you want to take care of this?
Also, is there any specific desired feature that is not available in 2.5?
We could go through the copy path ifn really needed.
El 30 ago. 2016 4:01 p. m., "Ignasi Barrera" <ig...@gmail.com>
escribió:
+1 to propose merging it to 2.6. It looks like it would be easier to
get a release there.
On 30 August 2016 at 16:00, Andrew Phillips <an...@apache.org> wrote:
>> Also, I don't think the exports are being added back, given the
>> comments in the PR, so we should consider:
>
>
> I just added this comment:
>
> https://github.com/google/gson/pull/916#issuecomment-243446866
>
> @nacx: would it make sense to propose merging this into 2.6.x rather than
> into master? It still leaves a breaking change in the 2.7.x releases, but
> might meet with less opposition from the Gson team?
>
> Perhaps also worth asking in the Gson user group if there are any
> recommendations how to work around/replace use of those classes?
>
> Regards
>
> ap
Re: Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1904
Posted by Ignasi Barrera <ig...@gmail.com>.
+1 to propose merging it to 2.6. It looks like it would be easier to
get a release there.
On 30 August 2016 at 16:00, Andrew Phillips <an...@apache.org> wrote:
>> Also, I don't think the exports are being added back, given the
>> comments in the PR, so we should consider:
>
>
> I just added this comment:
>
> https://github.com/google/gson/pull/916#issuecomment-243446866
>
> @nacx: would it make sense to propose merging this into 2.6.x rather than
> into master? It still leaves a breaking change in the 2.7.x releases, but
> might meet with less opposition from the Gson team?
>
> Perhaps also worth asking in the Gson user group if there are any
> recommendations how to work around/replace use of those classes?
>
> Regards
>
> ap
Re: Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1904
Posted by Andrew Phillips <an...@apache.org>.
> Also, I don't think the exports are being added back, given the
> comments in the PR, so we should consider:
I just added this comment:
https://github.com/google/gson/pull/916#issuecomment-243446866
@nacx: would it make sense to propose merging this into 2.6.x rather
than into master? It still leaves a breaking change in the 2.7.x
releases, but might meet with less opposition from the Gson team?
Perhaps also worth asking in the Gson user group if there are any
recommendations how to work around/replace use of those classes?
Regards
ap
Re: Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1904
Posted by Ignasi Barrera <ig...@gmail.com>.
UInfortunately, looking at what they do, it is difficult to workadound them :(
Also, I don't think the exports are being added back, given the
comments in the PR, so we should consider:
* Upgrading to Gson 2.5, which is the last version that exports those packages.
* Copy those classes in our jclouds-core tree and use them directly
(Gson is under an APache 2.0 license, so this is OK). This presents
the "upgrade/sync with upstream Gson" issues we can all imagine.
* Others?
On 30 August 2016 at 15:46, Andrew Phillips <an...@apache.org> wrote:
>> @demobox, please correct me if I'm wrong, as I'm not an OSGi expert at
>> all.
>
>
> Me neither, unfortunately ;-) But from a quick scan I think your reasoning
> is correct.
>
>> you'll see that the "com.google.gson.internal" is now excluded from the
>
>
> That would seem like a logical step, even if it's obviously not great from a
> backwards-compatibility perspective. Given the package name, I would assume
> that these classes were never meant to be used by consumers directly, so I
> think the "right" thing to do from our perspective would be to remove our
> dependencies on them.
>
> I'm not sure how much work that would involve, though.
>
> Regards
>
> ap
Re: Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1904
Posted by Andrew Phillips <an...@apache.org>.
> @demobox, please correct me if I'm wrong, as I'm not an OSGi expert at
> all.
Me neither, unfortunately ;-) But from a quick scan I think your
reasoning is correct.
> you'll see that the "com.google.gson.internal" is now excluded from the
That would seem like a logical step, even if it's obviously not great
from a backwards-compatibility perspective. Given the package name, I
would assume that these classes were never meant to be used by consumers
directly, so I think the "right" thing to do from our perspective would
be to remove our dependencies on them.
I'm not sure how much work that would involve, though.
Regards
ap
Re: Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1904
Posted by Ignasi Barrera <ig...@gmail.com>.
@demobox, please correct me if I'm wrong, as I'm not an OSGi expert at all.
Hmmm It looks like in Gson 2.6 the OSGi bundle configuration was
removed by accident [1] and the exports were restored in Gson 2.6.2
[2]. However, if you look at the comments of the pull request, you'll
see that the "com.google.gson.internal" is now excluded from the
exports, breaking backwards compatibility, and breaking jclouds-karaf.
The build after the gson upgrade complains about that package not
being available for the jclouds-core bundle.
A quick look in GitHub shows we're using it in just a few places [3],
but I don't really know if we can get rid of those. Perhaps after
upgrading to 2.7 there are alternative ways to achieve what the code
that uses internal packages is doing now (but I don't think so).
We have several options:
* Downgrade to Gson 2.5, which is the last version that exports the
gson internal packages.
* Try to add the exports back (I'm preparing a PR and see where the
discussion takes us).
* Others?
I.
[1] https://github.com/google/gson/issues/796
[2] https://github.com/google/gson/pull/797
[3] https://github.com/jclouds/jclouds/search?utf8=%E2%9C%93&q=%22com.google.gson.internal%22&type=Code
On 30 August 2016 at 08:47, Andrew Gaul <ga...@apache.org> wrote:
> I cannot resolve this issue; reverting the suspect gson commit yields
> similar but different errors on my development machine:
>
> ERROR: Bundle org.apache.sshd.core [26] Error starting mvn:org.apache.sshd/sshd-core/0.12.0 (org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sshd.core [26]: Unable to resolve 26.0: missing requirement [26.0] osgi.ee; (&(osgi.ee=JavaSE)(version=1.5)))
> org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sshd.core [26]: Unable to resolve 26.0: missing requirement [26.0] osgi.ee; (&(osgi.ee=JavaSE)(version=1.5))
>
> Can anyone help me investigate this?
>
> On Tue, Aug 30, 2016 at 12:44:05AM -0400, jenkins-no-reply@cloudbees.com wrote:
>> See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1904/>
>>
>
> --
> Andrew Gaul
> http://gaul.org/
Re: Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1904
Posted by Andrew Gaul <ga...@apache.org>.
I cannot resolve this issue; reverting the suspect gson commit yields
similar but different errors on my development machine:
ERROR: Bundle org.apache.sshd.core [26] Error starting mvn:org.apache.sshd/sshd-core/0.12.0 (org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sshd.core [26]: Unable to resolve 26.0: missing requirement [26.0] osgi.ee; (&(osgi.ee=JavaSE)(version=1.5)))
org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sshd.core [26]: Unable to resolve 26.0: missing requirement [26.0] osgi.ee; (&(osgi.ee=JavaSE)(version=1.5))
Can anyone help me investigate this?
On Tue, Aug 30, 2016 at 12:44:05AM -0400, jenkins-no-reply@cloudbees.com wrote:
> See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1904/>
>
--
Andrew Gaul
http://gaul.org/
Jenkins build is still unstable: jclouds-karaf » jclouds :: Karaf :: Integration Tests #1904
Posted by je...@cloudbees.com.
See <https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds.karaf$itests/1904/>