[jira] Commented: (HIVE-299) Include php packages for thrift service

["Gary Richardson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678172#action_12678172 ] 

Gary Richardson commented on HIVE-299:
--------------------------------------

Hi Raghotham,

It's not quite right. Here's what my packages/ directory looks like:

[root@ip-10-250-154-176 packages]# find . -type f
./hive_service/ThriftHive.php
./hive_service/hive_service_types.php
./hive_metastore/hive_metastore_constants.php
./hive_metastore/ThriftHiveMetastore.php
./hive_metastore/ThriftMetaStore.php
./hive_metastore/hive_metastore_types.php
./fb303/FacebookBase.php


You're missing the hive_service stuff. Plus they should be separated into their respective directories.

In my opinion, you should distribute:

[root@ip-10-250-154-176 packages]# find . -type f
./hive_service/ThriftHive.php
./hive_service/hive_service_types.php
./hive_metastore/hive_metastore_constants.php
./hive_metastore/ThriftHiveMetastore.php
./hive_metastore/ThriftMetaStore.php
./hive_metastore/hive_metastore_types.php

and the instructions for getting the PHP libs to work would be something like:

Copy the contents of build/dist/lib/php to your THRIFT_ROOT/packages directory. If you don't already have a THRIFT_ROOT, you need to get the base files from the thrift distribution, as well as the fb303 package.

> Include php packages for thrift service 
> ----------------------------------------
>
>                 Key: HIVE-299
>                 URL: https://issues.apache.org/jira/browse/HIVE-299
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.3.0
>            Reporter: Raghotham Murthy
>            Assignee: Raghotham Murthy
>             Fix For: 0.3.0
>
>         Attachments: hive-299.1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.