You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2016/01/28 14:22:55 UTC
svn commit: r1727341 -
/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/HeaderRenderer.java
Author: lofwyr
Date: Thu Jan 28 13:22:55 2016
New Revision: 1727341
URL: http://svn.apache.org/viewvc?rev=1727341&view=rev
Log:
TOBAGO-1529: Navbar, Toolbar, etc. for Bootstrap
- removing extra style classes, to have a simpler default
Modified:
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/HeaderRenderer.java
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/HeaderRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/HeaderRenderer.java?rev=1727341&r1=1727340&r2=1727341&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/HeaderRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/HeaderRenderer.java Thu Jan 28 13:22:55 2016
@@ -38,8 +38,9 @@ public class HeaderRenderer extends Rend
final UIHeader header = (UIHeader) component;
writer.startElement(HtmlElements.HEADER);
writer.writeIdAttribute(component.getClientId(facesContext));
- // TBD: BootstrapClass.NAVBAR_DEFAULT ?
- writer.writeClassAttribute(BootstrapClass.NAVBAR, BootstrapClass.NAVBAR_DARK, BootstrapClass.BG_INVERSE,
+ // TBD: NAVBAR_DARK and BG_INVERSE should not be the default
+ // TBD: how to configure it when it is needed, with customClass, or with markup?
+ writer.writeClassAttribute(BootstrapClass.NAVBAR, /*BootstrapClass.NAVBAR_DARK, BootstrapClass.BG_INVERSE,*/
header.isFixed() ? BootstrapClass.NAVBAR_FIXED_TOP : null);
// TBD: should NAVBAR class be in the NavRenderer?