You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Laszlo Puskas <lp...@hortonworks.com> on 2017/01/20 13:17:16 UTC
Review Request 55762: Ambari db-cleanup tool fixed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55762/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-19649
https://issues.apache.org/jira/browse/AMBARI-19649
Repository: ambari
Description
-------
The ambari-server db-cleanup tool failed due to unsatisfied guice dependencies.
The cause was that when the audit logging has been added, the related guice module hasn;t been set into the tool's injector.
The fix is to add the missing module to the db-cleanup tool's injector.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java f10250e
ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 0e2e0d8
Diff: https://reviews.apache.org/r/55762/diff/
Testing
-------
Manually.
Thanks,
Laszlo Puskas
Re: Review Request 55762: Ambari db-cleanup tool fixed
Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55762/
-----------------------------------------------------------
(Updated Jan. 24, 2017, 9:27 a.m.)
Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-19649
https://issues.apache.org/jira/browse/AMBARI-19649
Repository: ambari
Description (updated)
-------
The ambari-server db-cleanup tool failed due to unsatisfied guice dependencies.
The cause was that when the audit logging has been added, the related guice module hasn;t been set into the tool's injector.
The fix is to add the missing module to the db-cleanup tool's injector.
branch-2.5:
commit 8111ba662e849c27e4a9a04305b3ef2260c030e9
Author: Laszlo Puskas <lp...@hortonworks.com>
Date:?? Fri Jan 20 19:18:10 2017 +0100
????AMBARI-19649. Ambari purge tool broken. (Laszlo Puskas via stoader)
commit ec6ba0abbf2b1ce343f370f63512d45e7add9a40
Author: Laszlo Puskas <lp...@hortonworks.com>
Date:?? Fri Jan 20 23:18:13 2017 +0100
????AMBARI-19649. Ambari purge tool broken. (Laszlo Puskas via stoader)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java f10250e
ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 0e2e0d8
Diff: https://reviews.apache.org/r/55762/diff/
Testing
-------
Manually.
Thanks,
Laszlo Puskas
Re: Review Request 55762: Ambari db-cleanup tool fixed
Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55762/
-----------------------------------------------------------
(Updated Jan. 20, 2017, 9:19 p.m.)
Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-19649
https://issues.apache.org/jira/browse/AMBARI-19649
Repository: ambari
Description (updated)
-------
The ambari-server db-cleanup tool failed due to unsatisfied guice dependencies.
The cause was that when the audit logging has been added, the related guice module hasn;t been set into the tool's injector.
The fix is to add the missing module to the db-cleanup tool's injector.
branch-2.5:
commit 8111ba662e849c27e4a9a04305b3ef2260c030e9
Author: Laszlo Puskas <lp...@hortonworks.com>
Date:?? Fri Jan 20 19:18:10 2017 +0100
????AMBARI-19649. Ambari purge tool broken. (Laszlo Puskas via stoader)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java f10250e
ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 0e2e0d8
Diff: https://reviews.apache.org/r/55762/diff/
Testing
-------
Manually.
Thanks,
Laszlo Puskas
Re: Review Request 55762: Ambari db-cleanup tool fixed
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55762/#review162444
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Doroszlai
On Jan. 20, 2017, 2:17 p.m., Laszlo Puskas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55762/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 2:17 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19649
> https://issues.apache.org/jira/browse/AMBARI-19649
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ambari-server db-cleanup tool failed due to unsatisfied guice dependencies.
> The cause was that when the audit logging has been added, the related guice module hasn;t been set into the tool's injector.
>
> The fix is to add the missing module to the db-cleanup tool's injector.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java f10250e
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 0e2e0d8
>
> Diff: https://reviews.apache.org/r/55762/diff/
>
>
> Testing
> -------
>
> Manually.
>
>
> Thanks,
>
> Laszlo Puskas
>
>
Re: Review Request 55762: Ambari db-cleanup tool fixed
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55762/#review162415
-----------------------------------------------------------
Ship it!
Ship It!
- Sandor Magyari
On Jan. 20, 2017, 1:17 p.m., Laszlo Puskas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55762/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 1:17 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19649
> https://issues.apache.org/jira/browse/AMBARI-19649
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ambari-server db-cleanup tool failed due to unsatisfied guice dependencies.
> The cause was that when the audit logging has been added, the related guice module hasn;t been set into the tool's injector.
>
> The fix is to add the missing module to the db-cleanup tool's injector.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java f10250e
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 0e2e0d8
>
> Diff: https://reviews.apache.org/r/55762/diff/
>
>
> Testing
> -------
>
> Manually.
>
>
> Thanks,
>
> Laszlo Puskas
>
>
Re: Review Request 55762: Ambari db-cleanup tool fixed
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55762/#review162418
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Jan. 20, 2017, 2:17 p.m., Laszlo Puskas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55762/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 2:17 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19649
> https://issues.apache.org/jira/browse/AMBARI-19649
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ambari-server db-cleanup tool failed due to unsatisfied guice dependencies.
> The cause was that when the audit logging has been added, the related guice module hasn;t been set into the tool's injector.
>
> The fix is to add the missing module to the db-cleanup tool's injector.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java f10250e
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 0e2e0d8
>
> Diff: https://reviews.apache.org/r/55762/diff/
>
>
> Testing
> -------
>
> Manually.
>
>
> Thanks,
>
> Laszlo Puskas
>
>