[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #6265: [TE] rest-api - harleyjj/rca - add forecast as baseline option for me…

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #6265:
URL: https://github.com/apache/incubator-pinot/pull/6265#discussion_r524612083



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/BaselineParsingUtils.java
##########
@@ -31,6 +31,7 @@
 public class BaselineParsingUtils {
   private static final Pattern PATTERN_NONE = Pattern.compile("none");
   private static final Pattern PATTERN_PREDICTED = Pattern.compile("predicted");
+  private static final Pattern PATTERN_FORECAST = Pattern.compile("forecast");

Review comment:
       remove if this isn't used.

##########
File path: thirdeye/thirdeye-dashboard/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/RootCauseMetricResource.java
##########
@@ -102,14 +121,29 @@
   private final TimeSeriesLoader timeSeriesLoader;
   private final MetricConfigManager metricDAO;
   private final DatasetConfigManager datasetDAO;
+  private final EventManager eventDAO;
+  private final MergedAnomalyResultManager anomalyDAO;
+  private final EvaluationManager evaluationDAO;
+  private final DetectionPipelineLoader loader;
+  private final DataProvider dataProvider;
 
   public RootCauseMetricResource(ExecutorService executor, AggregationLoader aggregationLoader,
-      TimeSeriesLoader timeSeriesLoader, MetricConfigManager metricDAO, DatasetConfigManager datasetDAO) {
+      TimeSeriesLoader timeSeriesLoader, MetricConfigManager metricDAO, DatasetConfigManager datasetDAO,
+      EventManager eventDAO, MergedAnomalyResultManager anomalyDAO, EvaluationManager evaluationDAO) {
     this.executor = executor;
     this.aggregationLoader = aggregationLoader;
     this.timeSeriesLoader = timeSeriesLoader;
     this.metricDAO = metricDAO;
     this.datasetDAO = datasetDAO;
+    this.eventDAO = eventDAO;
+    this.anomalyDAO = anomalyDAO;
+    this.evaluationDAO = evaluationDAO;
+    this.loader = new DetectionPipelineLoader();

Review comment:
       is this one used anywhere? if not I would remove it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org