You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/20 06:27:13 UTC

[GitHub] [incubator-shardingsphere] avalon566 opened a new pull request #4039: Fix Postgres execute error sql no response (#3129)

avalon566 opened a new pull request #4039: Fix Postgres execute error sql no response (#3129)
URL: https://github.com/apache/incubator-shardingsphere/pull/4039
 
 
   Fixes #3129.
   
   Changes proposed in this pull request:
   
   - Add hasError method for QueryCommandExecutor.
   - Fix Postgres return error response.
   - Return backend error response to frontend.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4039: Fix Postgres execute error sql no response (#3129)

Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #4039: Fix Postgres execute error sql no response (#3129)
URL: https://github.com/apache/incubator-shardingsphere/pull/4039
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4039: Fix Postgres execute error sql no response (#3129)

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4039: Fix Postgres execute error sql no response (#3129)
URL: https://github.com/apache/incubator-shardingsphere/pull/4039#issuecomment-576134708
 
 
   ## Pull Request Test Coverage Report for [Build 1441](https://coveralls.io/builds/28205252)
   
   * **21** of **22**   **(95.45%)**  changed or added relevant lines in **6** files are covered.
   * **77** unchanged lines in **10** files lost coverage.
   * Overall coverage increased (+**0.2%**) to **67.014%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/PostgreSQLErrPacketFactory.java](https://coveralls.io/builds/28205252/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2FPostgreSQLErrPacketFactory.java#L50) | 8 | 9 | 88.89%
   <!-- | **Total:** | **21** | **22** | **95.45%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/auth/PostgreSQLAuthenticationEngine.java](https://coveralls.io/builds/28205252/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fauth%2FPostgreSQLAuthenticationEngine.java#L42) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/generic/PostgreSQLComTerminationExecutor.java](https://coveralls.io/builds/28205252/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fgeneric%2FPostgreSQLComTerminationExecutor.java#L31) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/generic/PostgreSQLUnsupportedCommandExecutor.java](https://coveralls.io/builds/28205252/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fgeneric%2FPostgreSQLUnsupportedCommandExecutor.java#L33) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/binary/bind/PostgreSQLComBindExecutor.java](https://coveralls.io/builds/28205252/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fquery%2Fbinary%2Fbind%2FPostgreSQLComBindExecutor.java#L129) | 1 | 40.0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/binary/describe/PostgreSQLComDescribeExecutor.java](https://coveralls.io/builds/28205252/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fquery%2Fbinary%2Fdescribe%2FPostgreSQLComDescribeExecutor.java#L32) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/binary/execute/PostgreSQLComExecuteExecutor.java](https://coveralls.io/builds/28205252/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fquery%2Fbinary%2Fexecute%2FPostgreSQLComExecuteExecutor.java#L32) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/binary/sync/PostgreSQLComSyncExecutor.java](https://coveralls.io/builds/28205252/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fquery%2Fbinary%2Fsync%2FPostgreSQLComSyncExecutor.java#L32) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/text/PostgreSQLComQueryExecutor.java](https://coveralls.io/builds/28205252/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fquery%2Ftext%2FPostgreSQLComQueryExecutor.java#L111) | 1 | 32.26% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/parser/SQLParserEngine.java](https://coveralls.io/builds/28205252/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fparser%2FSQLParserEngine.java#L63) | 15 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28205252/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L147) | 54 | 0% |
   <!-- | **Total:** | **77** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28205252/badge)](https://coveralls.io/builds/28205252) |
   | :-- | --: |
   | Change from base [Build 711](https://coveralls.io/builds/28203081): |  0.2% |
   | Covered Lines: | 10877 |
   | Relevant Lines: | 16231 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #4039: Fix Postgres execute error sql no response (#3129)

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #4039: Fix Postgres execute error sql no response (#3129)
URL: https://github.com/apache/incubator-shardingsphere/pull/4039#issuecomment-576154769
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4039: Fix Postgres execute error sql no response (#3129)

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4039: Fix Postgres execute error sql no response (#3129)
URL: https://github.com/apache/incubator-shardingsphere/pull/4039#issuecomment-576134708
 
 
   ## Pull Request Test Coverage Report for [Build 1433](https://coveralls.io/builds/28203853)
   
   * **21** of **22**   **(95.45%)**  changed or added relevant lines in **6** files are covered.
   * **45** unchanged lines in **9** files lost coverage.
   * Overall coverage increased (+**0.04%**) to **66.831%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/PostgreSQLErrPacketFactory.java](https://coveralls.io/builds/28203853/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2FPostgreSQLErrPacketFactory.java#L50) | 8 | 9 | 88.89%
   <!-- | **Total:** | **21** | **22** | **95.45%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/auth/PostgreSQLAuthenticationEngine.java](https://coveralls.io/builds/28203853/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fauth%2FPostgreSQLAuthenticationEngine.java#L42) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/generic/PostgreSQLComTerminationExecutor.java](https://coveralls.io/builds/28203853/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fgeneric%2FPostgreSQLComTerminationExecutor.java#L31) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/generic/PostgreSQLUnsupportedCommandExecutor.java](https://coveralls.io/builds/28203853/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fgeneric%2FPostgreSQLUnsupportedCommandExecutor.java#L33) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/binary/bind/PostgreSQLComBindExecutor.java](https://coveralls.io/builds/28203853/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fquery%2Fbinary%2Fbind%2FPostgreSQLComBindExecutor.java#L129) | 1 | 40.0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/binary/describe/PostgreSQLComDescribeExecutor.java](https://coveralls.io/builds/28203853/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fquery%2Fbinary%2Fdescribe%2FPostgreSQLComDescribeExecutor.java#L32) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/binary/execute/PostgreSQLComExecuteExecutor.java](https://coveralls.io/builds/28203853/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fquery%2Fbinary%2Fexecute%2FPostgreSQLComExecuteExecutor.java#L32) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/binary/sync/PostgreSQLComSyncExecutor.java](https://coveralls.io/builds/28203853/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fquery%2Fbinary%2Fsync%2FPostgreSQLComSyncExecutor.java#L32) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/text/PostgreSQLComQueryExecutor.java](https://coveralls.io/builds/28203853/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2Fquery%2Ftext%2FPostgreSQLComQueryExecutor.java#L111) | 1 | 32.26% |
   | [sharding-orchestration/sharding-orchestration-config/sharding-orchestration-config-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/config/zookeeper/curator/CuratorZookeeperConfigCenter.java](https://coveralls.io/builds/28203853/source?filename=sharding-orchestration%2Fsharding-orchestration-config%2Fsharding-orchestration-config-zookeeper-curator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fconfig%2Fzookeeper%2Fcurator%2FCuratorZookeeperConfigCenter.java#L69) | 37 | 2.73% |
   <!-- | **Total:** | **45** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28203853/badge)](https://coveralls.io/builds/28203853) |
   | :-- | --: |
   | Change from base [Build 711](https://coveralls.io/builds/28203081): |  0.04% |
   | Covered Lines: | 10840 |
   | Relevant Lines: | 16220 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services