You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/13 14:05:14 UTC

[GitHub] [dubbo] codecov-commenter commented on pull request #8788: Add [annotation] test case for ServiceDefinitionBuilderTest & remove unused parameter

codecov-commenter commented on pull request #8788:
URL: https://github.com/apache/dubbo/pull/8788#issuecomment-918226411


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8788?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8788](https://codecov.io/gh/apache/dubbo/pull/8788?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d48b2c1) into [3.0](https://codecov.io/gh/apache/dubbo/commit/1b100f84cb51a590c865e2d28d159b4d4c203409?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b100f8) will **increase** coverage by `0.14%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8788/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8788      +/-   ##
   ============================================
   + Coverage     63.70%   63.84%   +0.14%     
   - Complexity      312      313       +1     
   ============================================
     Files          1145     1151       +6     
     Lines         48188    48334     +146     
     Branches       7255     7259       +4     
   ============================================
   + Hits          30699    30860     +161     
   + Misses        14123    14093      -30     
   - Partials       3366     3381      +15     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../metadata/definition/builder/ArrayTypeBuilder.java](https://codecov.io/gh/apache/dubbo/pull/8788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9kZWZpbml0aW9uL2J1aWxkZXIvQXJyYXlUeXBlQnVpbGRlci5qYXZh) | `80.00% <ø> (ø)` | |
   | [...data/definition/builder/CollectionTypeBuilder.java](https://codecov.io/gh/apache/dubbo/pull/8788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9kZWZpbml0aW9uL2J1aWxkZXIvQ29sbGVjdGlvblR5cGVCdWlsZGVyLmphdmE=) | `64.28% <ø> (ø)` | |
   | [...o/metadata/definition/builder/EnumTypeBuilder.java](https://codecov.io/gh/apache/dubbo/pull/8788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9kZWZpbml0aW9uL2J1aWxkZXIvRW51bVR5cGVCdWlsZGVyLmphdmE=) | `77.27% <ø> (ø)` | |
   | [...bo/metadata/definition/builder/MapTypeBuilder.java](https://codecov.io/gh/apache/dubbo/pull/8788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9kZWZpbml0aW9uL2J1aWxkZXIvTWFwVHlwZUJ1aWxkZXIuamF2YQ==) | `72.41% <ø> (ø)` | |
   | [...bbo/metadata/definition/TypeDefinitionBuilder.java](https://codecov.io/gh/apache/dubbo/pull/8788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9kZWZpbml0aW9uL1R5cGVEZWZpbml0aW9uQnVpbGRlci5qYXZh) | `92.00% <100.00%> (ø)` | |
   | [...ian2/dubbo/AbstractHessian2FactoryInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL2R1YmJvL0Fic3RyYWN0SGVzc2lhbjJGYWN0b3J5SW5pdGlhbGl6ZXIuamF2YQ==) | `81.81% <0.00%> (-18.19%)` | :arrow_down: |
   | [...va/org/apache/dubbo/metadata/RevisionResolver.java](https://codecov.io/gh/apache/dubbo/pull/8788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9SZXZpc2lvblJlc29sdmVyLmphdmE=) | `50.00% <0.00%> (-16.67%)` | :arrow_down: |
   | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/dubbo/pull/8788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkbG9jYWwvSW50ZXJuYWxUaHJlYWRMb2NhbE1hcC5qYXZh) | `74.02% <0.00%> (-15.17%)` | :arrow_down: |
   | [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/8788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `50.00% <0.00%> (-14.00%)` | :arrow_down: |
   | [...va/org/apache/dubbo/remoting/exchange/Request.java](https://codecov.io/gh/apache/dubbo/pull/8788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9SZXF1ZXN0LmphdmE=) | `75.43% <0.00%> (-12.80%)` | :arrow_down: |
   | ... and [133 more](https://codecov.io/gh/apache/dubbo/pull/8788/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8788?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8788?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1b100f8...d48b2c1](https://codecov.io/gh/apache/dubbo/pull/8788?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org