[GitHub] [arrow] alamb commented on a change in pull request #8906: ARROW-10817: [Rust][DataFusion] Update relevant tpch-queries with BETWEEN

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #8906:
URL: https://github.com/apache/arrow/pull/8906#discussion_r542684693



##########
File path: rust/benchmarks/src/bin/tpch.rs
##########
@@ -400,7 +400,7 @@ fn create_logical_plan(ctx: &mut ExecutionContext, query: usize) -> Result<Logic
                             (n1.n_name = 'FRANCE' and n2.n_name = 'GERMANY')
                             or (n1.n_name = 'GERMANY' and n2.n_name = 'FRANCE')
                         )
-                        and l_shipdate > date '1995-01-01' and l_shipdate < date '1996-12-31'
+                        and l_shipdate between date '1995-01-01' and date '1996-12-31'

Review comment:
       I think we can use the TPC-H Query validation section to resolve the use of `<` or `<=` etc by running the query against SF1 data and comparing the result
   
   According to the spec, the expected answer is `123141078.23` at SF1 
   
   http://www.tpc.org/tpc_documents_current_versions/pdf/tpc-h_v2.17.2.pdf
   page 38
   
   
   ```
   REVENUE
   123141078.23
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org