You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/27 19:09:57 UTC
[GitHub] [incubator-mxnet] ChaiBapchya opened a new pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
ChaiBapchya opened a new pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178
## Description ##
NightlyTestforBinaries for 1.7.x and master revealed error with with_seed path
Fixing it in master & will cherry-pick the fix to 1.7.x branch
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/NightlyTestsForBinaries/detail/master/670/pipeline
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/NightlyTestsForBinaries/detail/v1.7.x/1/pipeline
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- [ ] Code is well-documented:
@ciyongch @access2rohit @apeforest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#discussion_r417020159
##########
File path: tests/nightly/test_large_array.py
##########
@@ -27,7 +27,7 @@
from mxnet.test_utils import rand_ndarray, assert_almost_equal, rand_coord_2d, default_context, check_symbolic_forward, create_2d_tensor
from mxnet import gluon, nd
-from common import with_seed, with_post_test_cleanup
Review comment:
Why remove this? It attempts to free up memory after each test passes. Its good to keep it in order to avoid OOM on CI instances due to large memory consumption nature of these tests.
Its not perfect but better than nothing at all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on a change in pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#discussion_r416181089
##########
File path: tests/nightly/test_large_vector.py
##########
@@ -27,7 +27,7 @@
from mxnet.test_utils import rand_ndarray, assert_almost_equal, rand_coord_2d, create_vector
from mxnet import gluon, nd
-from tests.python.unittest.common import with_seed
+from common import with_seed
Review comment:
Since while looking into the large_vector & large_tensor scripts, I realized that I had added the with_post_test_cleanup function but it is not being used anywhere anymore. So I am removing it as a cleanup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#discussion_r417046220
##########
File path: tests/nightly/test_large_array.py
##########
@@ -27,7 +27,7 @@
from mxnet.test_utils import rand_ndarray, assert_almost_equal, rand_coord_2d, default_context, check_symbolic_forward, create_2d_tensor
from mxnet import gluon, nd
-from common import with_seed, with_post_test_cleanup
Review comment:
I think tt's unused currently? You can search for with_post_test_cleanup in the source code and there's no place it's called
If we need this functionality, I suggest to implement it via pytest API in the `conftest.py` file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#issuecomment-620176765
Hey @ChaiBapchya , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, centos-gpu, windows-cpu, unix-gpu, centos-cpu, edge, clang, miscellaneous, website, unix-cpu, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#issuecomment-620244396
How is removing something without replacement a fix? Please elaborate - apparently this was put in place for a reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#issuecomment-622600123
@ciyongch Backported to 1.7.x
Pl review/merge
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#issuecomment-620723506
@mxnet-bot run ci [centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya edited a comment on pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
ChaiBapchya edited a comment on pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#issuecomment-622600123
@ciyongch Backported to 1.7.x #18220
Pl review/merge
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#discussion_r417020159
##########
File path: tests/nightly/test_large_array.py
##########
@@ -27,7 +27,7 @@
from mxnet.test_utils import rand_ndarray, assert_almost_equal, rand_coord_2d, default_context, check_symbolic_forward, create_2d_tensor
from mxnet import gluon, nd
-from common import with_seed, with_post_test_cleanup
Review comment:
Why remove this? It attempts to free up memory after each test passes. Its good to keep it in order to avoid OOM on CI instances due to large memory consumption nature of these tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on a change in pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#discussion_r416176721
##########
File path: tests/nightly/test_large_vector.py
##########
@@ -27,7 +27,7 @@
from mxnet.test_utils import rand_ndarray, assert_almost_equal, rand_coord_2d, create_vector
from mxnet import gluon, nd
-from tests.python.unittest.common import with_seed
+from common import with_seed
Review comment:
this was the issue. Incorrect path used @marcoabreu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#discussion_r417020159
##########
File path: tests/nightly/test_large_array.py
##########
@@ -27,7 +27,7 @@
from mxnet.test_utils import rand_ndarray, assert_almost_equal, rand_coord_2d, default_context, check_symbolic_forward, create_2d_tensor
from mxnet import gluon, nd
-from common import with_seed, with_post_test_cleanup
Review comment:
Why remove this? It attempts to free up memory after each test passes. Its good to keep it in order to avoid OOM on CI instances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#issuecomment-620854367
@mxnet-label-bot update [pr-awaiting-merge]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#issuecomment-620723571
Jenkins CI successfully triggered : [centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#issuecomment-620895946
Testing this on : http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/nightly_chai/detail/fix_large_vector_nightly/1/pipeline [triggering the failing nightly build on this branch fix on CI Prod]
Will delete the pipeline once PR merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #18178: Fix nightly large_vector test caused by incorrect with_seed path
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on a change in pull request #18178:
URL: https://github.com/apache/incubator-mxnet/pull/18178#discussion_r416179243
##########
File path: tests/nightly/test_large_vector.py
##########
@@ -27,7 +27,7 @@
from mxnet.test_utils import rand_ndarray, assert_almost_equal, rand_coord_2d, create_vector
from mxnet import gluon, nd
-from tests.python.unittest.common import with_seed
+from common import with_seed
Review comment:
Right, but why are you deleting the cleanups script?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org