[GitHub] [maven-checkstyle-plugin] stevenschenk commented on a change in pull request #47: [MCHECKSTYLE-401] - NullPointerException in Violation class

[GitBox <gi...@apache.org>]

stevenschenk commented on a change in pull request #47:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/47#discussion_r645558785



##########
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
##########
@@ -196,10 +196,10 @@ public boolean equals( Object other )
       return false;
     }
     Violation violation = ( Violation ) other;
-    return line.equals( violation.line )
+    return Objects.equals( line, violation.line )

Review comment:
       I added a test for the equals method. Could you elaborate on what you specifically want to be tested?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org