[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1943: Upstream implementation of typed query variables

[GitBox <gi...@apache.org>]

xudong963 commented on a change in pull request #1943:
URL: https://github.com/apache/arrow-datafusion/pull/1943#discussion_r821243638



##########
File path: datafusion-expr/src/expr.rs
##########
@@ -399,7 +399,7 @@ impl fmt::Debug for Expr {
         match self {
             Expr::Alias(expr, alias) => write!(f, "{:?} AS {}", expr, alias),
             Expr::Column(c) => write!(f, "{}", c),
-            Expr::ScalarVariable(var_names) => write!(f, "{}", var_names.join(".")),
+            Expr::ScalarVariable(_, var_names) => write!(f, "{}", var_names.join(".")),

Review comment:
       It'll be better to print the data type, such as
   `Expr::ScalarVariable(data_type, var_names) => write!(f, "{}, data type: {}", var_names.join("."), data_type),`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org