You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/18 11:42:00 UTC
[GitHub] [superset] PrabuSarvesan opened a new issue, #21852: Chart width not refreshed properly while tab switch
PrabuSarvesan opened a new issue, #21852:
URL: https://github.com/apache/superset/issues/21852
#### How to reproduce the bug
1. Open Sales dashboard in Superset application.
2. Go to Exploratory tab and toggle(expand/collapse) the dashboard filter.
3. Switch back again to Sales Overview tab.
### Expected results
Total revenue chart should be resized based on modified size.
### Actual results
Total revenue chart was not resized with modified size. This issue occurs for all charts.
#### Screenshots
### Environment
- browser type and version: Chrome
- superset version: Latest source from GitHub
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [*] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [*] I have reproduced the issue with at least the latest released version of superset.
- [*] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
**shouldComponentUpdate returns false** in **superset-frontend/src/dashboard/components/gridComponents/Chart.jsx** while tab switch. Following condition was not met,
if (
nextProps.width !== this.props.width ||
nextProps.height !== this.props.height
) {
clearTimeout(this.resizeTimeout);
this.resizeTimeout = setTimeout(this.resize, RESIZE_TIMEOUT);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] PrabuSarvesan closed issue #21852: Chart width not refreshed properly while tab switch
Posted by "PrabuSarvesan (via GitHub)" <gi...@apache.org>.
PrabuSarvesan closed issue #21852: Chart width not refreshed properly while tab switch
URL: https://github.com/apache/superset/issues/21852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Shazad-khan commented on issue #21852: Chart width not refreshed properly while tab switch
Posted by "Shazad-khan (via GitHub)" <gi...@apache.org>.
Shazad-khan commented on issue #21852:
URL: https://github.com/apache/superset/issues/21852#issuecomment-1475707243
It is working as expected please recheck it and close the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org