You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by dk...@apache.org on 2008/07/03 01:34:16 UTC

svn commit: r673548 - in /cxf/trunk: api/src/main/java/org/apache/cxf/phase/ api/src/main/java/org/apache/cxf/service/model/ api/src/main/java/org/apache/cxf/wsdl/ api/src/test/java/org/apache/cxf/phase/ api/src/test/java/org/apache/cxf/ws/policy/build...

Author: dkulp
Date: Wed Jul  2 16:34:15 2008
New Revision: 673548

URL: http://svn.apache.org/viewvc?rev=673548&view=rev
Log:
Fix a bunch of warnings that are showing up with the ganymede compiler

Modified:
    cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java
    cxf/trunk/api/src/main/java/org/apache/cxf/service/model/ServiceModelUtil.java
    cxf/trunk/api/src/main/java/org/apache/cxf/wsdl/EndpointReferenceUtils.java
    cxf/trunk/api/src/test/java/org/apache/cxf/phase/PhaseInterceptorChainTest.java
    cxf/trunk/api/src/test/java/org/apache/cxf/ws/policy/builder/jaxb/JaxbAssertionBuilderTest.java
    cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/ResourceAdapterInternalException.java
    cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaHandlerUtils.java
    cxf/trunk/rt/bindings/xml/src/main/java/org/apache/cxf/binding/xml/XMLFormatValidator.java
    cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/basic/ArrayType.java
    cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/collection/CollectionType.java
    cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/encoded/SoapArrayType.java
    cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/java5/Java5TypeCreator.java
    cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/util/stax/JDOMStreamReader.java
    cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/type/map/MapsTest.java
    cxf/trunk/rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/JAXBEncoderDecoder.java
    cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/JAXRSInvoker.java
    cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/JAXRSServerFactoryBean.java
    cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseBuilderImpl.java
    cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/interceptor/JAXRSOutInterceptor.java
    cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/AbstractResourceInfo.java
    cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java
    cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/DefaultServiceConfiguration.java
    cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/SOAPBindingUtil.java
    cxf/trunk/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/processor/internal/ParameterProcessor.java
    cxf/trunk/tools/wsdlto/test/src/test/java/org/apache/cxf/tools/wsdlto/jaxws/CodeGenTest.java

Modified: cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java
URL: http://svn.apache.org/viewvc/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java (original)
+++ cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java Wed Jul  2 16:34:15 2008
@@ -279,7 +279,6 @@
      * @param startingAfterInterceptorID the id of the interceptor 
      * @throws Exception
      */
-    @SuppressWarnings("unchecked")
     public synchronized boolean doInterceptStartingAfter(Message message,
                                                          String startingAfterInterceptorID) {
         updateIterator();
@@ -300,7 +299,6 @@
      * @param startingAtInterceptorID the id of the interceptor 
      * @throws Exception
      */
-    @SuppressWarnings("unchecked")
     public synchronized boolean doInterceptStartingAt(Message message,
                                                          String startingAtInterceptorID) {
         updateIterator();

Modified: cxf/trunk/api/src/main/java/org/apache/cxf/service/model/ServiceModelUtil.java
URL: http://svn.apache.org/viewvc/cxf/trunk/api/src/main/java/org/apache/cxf/service/model/ServiceModelUtil.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/api/src/main/java/org/apache/cxf/service/model/ServiceModelUtil.java (original)
+++ cxf/trunk/api/src/main/java/org/apache/cxf/service/model/ServiceModelUtil.java Wed Jul  2 16:34:15 2008
@@ -132,7 +132,7 @@
     public static List<String> getOperationInputPartNames(OperationInfo operation) {
         List<String> names = new ArrayList<String>();
         List<MessagePartInfo> parts = operation.getInput().getMessageParts();
-        if (parts == null && parts.size() == 0) {
+        if (parts == null || parts.size() == 0) {
             return names;
         }
 

Modified: cxf/trunk/api/src/main/java/org/apache/cxf/wsdl/EndpointReferenceUtils.java
URL: http://svn.apache.org/viewvc/cxf/trunk/api/src/main/java/org/apache/cxf/wsdl/EndpointReferenceUtils.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/api/src/main/java/org/apache/cxf/wsdl/EndpointReferenceUtils.java (original)
+++ cxf/trunk/api/src/main/java/org/apache/cxf/wsdl/EndpointReferenceUtils.java Wed Jul  2 16:34:15 2008
@@ -500,7 +500,7 @@
                             doTransform = false;
                         }
                     } else if (source instanceof DOMSource) {
-                        node = ((DOMSource)node).getNode();
+                        node = ((DOMSource)source).getNode();
                         doTransform = false;
                     } 
                     

Modified: cxf/trunk/api/src/test/java/org/apache/cxf/phase/PhaseInterceptorChainTest.java
URL: http://svn.apache.org/viewvc/cxf/trunk/api/src/test/java/org/apache/cxf/phase/PhaseInterceptorChainTest.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/api/src/test/java/org/apache/cxf/phase/PhaseInterceptorChainTest.java (original)
+++ cxf/trunk/api/src/test/java/org/apache/cxf/phase/PhaseInterceptorChainTest.java Wed Jul  2 16:34:15 2008
@@ -313,7 +313,6 @@
         return setUpPhaseInterceptor(phase, id, null, null);
     }
 
-    @SuppressWarnings("unchecked")
     AbstractPhaseInterceptor setUpPhaseInterceptor(final String phase, 
                                                    final String id,
                                                    Set<String> b,

Modified: cxf/trunk/api/src/test/java/org/apache/cxf/ws/policy/builder/jaxb/JaxbAssertionBuilderTest.java
URL: http://svn.apache.org/viewvc/cxf/trunk/api/src/test/java/org/apache/cxf/ws/policy/builder/jaxb/JaxbAssertionBuilderTest.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/api/src/test/java/org/apache/cxf/ws/policy/builder/jaxb/JaxbAssertionBuilderTest.java (original)
+++ cxf/trunk/api/src/test/java/org/apache/cxf/ws/policy/builder/jaxb/JaxbAssertionBuilderTest.java Wed Jul  2 16:34:15 2008
@@ -61,7 +61,6 @@
     }
     
     @Test
-    @SuppressWarnings("unchecked")
     public void testBuild() throws Exception {
         QName qn = new QName("http://cxf.apache.org/test/assertions/foo", "FooType");
         JaxbAssertionBuilder<FooType> ab = new JaxbAssertionBuilder<FooType>(FooType.class, qn);

Modified: cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/ResourceAdapterInternalException.java
URL: http://svn.apache.org/viewvc/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/ResourceAdapterInternalException.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/ResourceAdapterInternalException.java (original)
+++ cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/ResourceAdapterInternalException.java Wed Jul  2 16:34:15 2008
@@ -72,7 +72,6 @@
     }
 
 
-    @SuppressWarnings("deprecation")
     public Exception getLinkedException() {
         Exception linkedEx = null;
         if (getCause() instanceof Exception) {

Modified: cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaHandlerUtils.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaHandlerUtils.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaHandlerUtils.java (original)
+++ cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaHandlerUtils.java Wed Jul  2 16:34:15 2008
@@ -370,7 +370,8 @@
         if (schemaType instanceof XmlSchemaElement) {
             stype = ((XmlSchemaElement) schemaType).getSchemaType();
             if (stype == null) {
-                stype = CorbaUtils.getXmlSchemaType(serviceInfo, el.getRefName());
+                stype = CorbaUtils.getXmlSchemaType(serviceInfo, 
+                                                    ((XmlSchemaElement) schemaType).getRefName());
             }
         }
         

Modified: cxf/trunk/rt/bindings/xml/src/main/java/org/apache/cxf/binding/xml/XMLFormatValidator.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/bindings/xml/src/main/java/org/apache/cxf/binding/xml/XMLFormatValidator.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/bindings/xml/src/main/java/org/apache/cxf/binding/xml/XMLFormatValidator.java (original)
+++ cxf/trunk/rt/bindings/xml/src/main/java/org/apache/cxf/binding/xml/XMLFormatValidator.java Wed Jul  2 16:34:15 2008
@@ -49,7 +49,6 @@
         return checkXMLBindingFormat();
     }
 
-    @SuppressWarnings("unchecked")
     private boolean checkXMLBindingFormat() {
         Collection<BindingInfo> bindings = service.getBindings();
         if (bindings != null) {
@@ -63,7 +62,6 @@
         return true;
     }
 
-    @SuppressWarnings("unchecked")
     private boolean checkXMLFormat(BindingInfo binding) {
         Collection<BindingOperationInfo> bos = binding.getOperations();
         boolean result = true;

Modified: cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/basic/ArrayType.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/basic/ArrayType.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/basic/ArrayType.java (original)
+++ cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/basic/ArrayType.java Wed Jul  2 16:34:15 2008
@@ -173,6 +173,9 @@
         }
 
         Type type = getComponentType();
+        if (type == null) {
+            throw new DatabindingException("Couldn't find type for array.");
+        }
         if (XmlSchemaConstants.ANY_TYPE_QNAME.equals(type.getSchemaType())) {
             forceXsiWrite = true;
         }
@@ -186,9 +189,6 @@
 
         String name = type.getSchemaType().getLocalPart();
 
-        if (type == null) {
-            throw new DatabindingException("Couldn't find type for " + type.getTypeClass() + ".");
-        }
 
         Class arrayType = type.getTypeClass();
 

Modified: cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/collection/CollectionType.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/collection/CollectionType.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/collection/CollectionType.java (original)
+++ cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/collection/CollectionType.java Wed Jul  2 16:34:15 2008
@@ -90,7 +90,7 @@
             Type type = getComponentType();
 
             if (type == null) {
-                throw new DatabindingException("Couldn't find type for " + type.getTypeClass() + ".");
+                throw new DatabindingException("Couldn't find component type for Collection.");
             }
 
             for (Iterator itr = list.iterator(); itr.hasNext();) {

Modified: cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/encoded/SoapArrayType.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/encoded/SoapArrayType.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/encoded/SoapArrayType.java (original)
+++ cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/encoded/SoapArrayType.java Wed Jul  2 16:34:15 2008
@@ -284,7 +284,7 @@
         // ComponentType
         Type type = getComponentType();
         if (type == null) {
-            throw new DatabindingException("Couldn't find type for " + type.getTypeClass() + ".");
+            throw new DatabindingException("Couldn't find component type for array.");
         }
 
         // Root component's schema type

Modified: cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/java5/Java5TypeCreator.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/java5/Java5TypeCreator.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/java5/Java5TypeCreator.java (original)
+++ cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/java5/Java5TypeCreator.java Wed Jul  2 16:34:15 2008
@@ -193,7 +193,6 @@
         return paramClass;
     }
 
-    @SuppressWarnings("unchecked")
     @Override
     public Type createDefaultType(TypeClassInfo info) {
         QName typeName = info.getTypeName();
@@ -235,7 +234,6 @@
         return type;
     }
 
-    @SuppressWarnings("unchecked")
     @Override
     public QName createQName(Class typeClass) {
         String name = annotationReader.getName(typeClass);

Modified: cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/util/stax/JDOMStreamReader.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/util/stax/JDOMStreamReader.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/util/stax/JDOMStreamReader.java (original)
+++ cxf/trunk/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/util/stax/JDOMStreamReader.java Wed Jul  2 16:34:15 2008
@@ -175,10 +175,9 @@
     }
 
     @Override
-    @SuppressWarnings("unchecked")
     protected void endElement() {
         if (namespaceStack.size() > 0) {
-            prefix2decNs = (Map<String, Namespace>)namespaceStack.pop();
+            prefix2decNs = namespaceStack.pop();
         }
     }
 

Modified: cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/type/map/MapsTest.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/type/map/MapsTest.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/type/map/MapsTest.java (original)
+++ cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/type/map/MapsTest.java Wed Jul  2 16:34:15 2008
@@ -73,8 +73,6 @@
     @Ignore
     @Test
     public void testMapWsdl() throws WSDLException {
-        @SuppressWarnings("unused")
-        //Document wsdl = getWSDLDocument("MapTestService");
         Definition wsdlDef = getWSDLDefinition("MapTestService");
         StringWriter sink = new StringWriter();
         WSDLFactory.newInstance().newWSDLWriter().writeWSDL(wsdlDef, sink);

Modified: cxf/trunk/rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/JAXBEncoderDecoder.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/JAXBEncoderDecoder.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/JAXBEncoderDecoder.java (original)
+++ cxf/trunk/rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/JAXBEncoderDecoder.java Wed Jul  2 16:34:15 2008
@@ -220,7 +220,6 @@
     }
     
 //  TODO: cache the JAXBRIContext
-    @SuppressWarnings("unchecked")
     public static Object unmarshalWithBridge(TypeReference ref,
                                              Set<Class<?>> ctxClasses,
                                              Object source,
@@ -304,7 +303,6 @@
         }
     }
 
-    @SuppressWarnings("unchecked")
     public static Exception unmarshallException(Unmarshaller u, 
                                                 Object source,
                                                 MessagePartInfo part) {

Modified: cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/JAXRSInvoker.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/JAXRSInvoker.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/JAXRSInvoker.java (original)
+++ cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/JAXRSInvoker.java Wed Jul  2 16:34:15 2008
@@ -163,7 +163,7 @@
                                                                        contentType, 
                                                                        acceptContentType);
             
-            if (subCri == null) {
+            if (subOri == null) {
                 org.apache.cxf.common.i18n.Message errorM = 
                     new org.apache.cxf.common.i18n.Message("NO_SUBRESOURCE_METHOD_FOUND",  
                                                            BUNDLE, 

Modified: cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/JAXRSServerFactoryBean.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/JAXRSServerFactoryBean.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/JAXRSServerFactoryBean.java (original)
+++ cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/JAXRSServerFactoryBean.java Wed Jul  2 16:34:15 2008
@@ -78,7 +78,6 @@
         setBindingId(JAXRSBindingFactory.JAXRS_BINDING_ID);
     }
     
-    @SuppressWarnings("unchecked")
     public Server create() {
         try {
             Endpoint ep = createEndpoint();

Modified: cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseBuilderImpl.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseBuilderImpl.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseBuilderImpl.java (original)
+++ cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseBuilderImpl.java Wed Jul  2 16:34:15 2008
@@ -124,7 +124,6 @@
         return this;
     }
     
-    @SuppressWarnings("unchecked")
     public ResponseBuilder header(String name, Object value) {
         metadata.add(name, value.toString());
         return this;

Modified: cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/interceptor/JAXRSOutInterceptor.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/interceptor/JAXRSOutInterceptor.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/interceptor/JAXRSOutInterceptor.java (original)
+++ cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/interceptor/JAXRSOutInterceptor.java Wed Jul  2 16:34:15 2008
@@ -54,7 +54,6 @@
         super(Phase.MARSHAL);
     }
 
-    @SuppressWarnings("unchecked")
     public void handleMessage(Message message) {
         
         try {

Modified: cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/AbstractResourceInfo.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/AbstractResourceInfo.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/AbstractResourceInfo.java (original)
+++ cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/AbstractResourceInfo.java Wed Jul  2 16:34:15 2008
@@ -161,19 +161,16 @@
         return ret;
     }
     
-    @SuppressWarnings("unchecked")
     public ThreadLocalProxy getContextFieldProxy(Field f) {
         return fieldProxyMap == null ? null
                : fieldProxyMap.get(f);
     }
     
-    @SuppressWarnings("unchecked")
     public ThreadLocalProxy getResourceFieldProxy(Field f) {
         return resourceProxyMap == null ? null
                : resourceProxyMap.get(f);
     }
     
-    @SuppressWarnings("unchecked")
     public ThreadLocalProxy getContextSetterProxy(Method m) {
         return setterProxyMap == null ? null : setterProxyMap.get(m);
     }

Modified: cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java (original)
+++ cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java Wed Jul  2 16:34:15 2008
@@ -471,7 +471,6 @@
         return value.length() > 0 ? InjectionUtils.handleParameter(value, pClass) : defaultValue;
     }
     
-    @SuppressWarnings("unchecked")
     public static Object createContextValue(Message m, Type genericType, Class<?> clazz) {
  
         Object o = null;
@@ -551,7 +550,6 @@
     
     
     //TODO : multiple query string parsing, do it once
-    @SuppressWarnings("unchecked")
     private static Object readQueryString(QueryParam queryParam,
                                           Class<?> paramType,
                                           Type genericType,

Modified: cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/DefaultServiceConfiguration.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/DefaultServiceConfiguration.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/DefaultServiceConfiguration.java (original)
+++ cxf/trunk/rt/frontend/simple/src/main/java/org/apache/cxf/service/factory/DefaultServiceConfiguration.java Wed Jul  2 16:34:15 2008
@@ -106,7 +106,7 @@
     private String getDefaultLocalName(OperationInfo op, Method method, int paramNumber, String prefix) {
         Class<?> impl = getServiceFactory().getServiceClass();
         // try to grab the implementation class so we can read the debug symbols from it
-        if (impl == null) {
+        if (impl != null) {
             try {
                 method = impl.getMethod(method.getName(), method.getParameterTypes());
             } catch (Exception e) {

Modified: cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/SOAPBindingUtil.java
URL: http://svn.apache.org/viewvc/cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/SOAPBindingUtil.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/SOAPBindingUtil.java (original)
+++ cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/SOAPBindingUtil.java Wed Jul  2 16:34:15 2008
@@ -276,7 +276,6 @@
         return obj instanceof SOAPBinding || obj instanceof SOAP12Binding;
     }
 
-    @SuppressWarnings("unchecked")
     public static List<SoapFault> getBindingOperationSoapFaults(BindingOperation bop) {
         List<SoapFault> faults = new ArrayList<SoapFault>();
         Map bindingFaults = bop.getBindingFaults();

Modified: cxf/trunk/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/processor/internal/ParameterProcessor.java
URL: http://svn.apache.org/viewvc/cxf/trunk/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/processor/internal/ParameterProcessor.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/processor/internal/ParameterProcessor.java (original)
+++ cxf/trunk/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/processor/internal/ParameterProcessor.java Wed Jul  2 16:34:15 2008
@@ -54,7 +54,6 @@
 
     private DataBindingProfile dataBinding;
 
-    @SuppressWarnings("unchecked")
     public ParameterProcessor(ToolContext penv) {
         super(penv);
         dataBinding = context.get(DataBindingProfile.class);

Modified: cxf/trunk/tools/wsdlto/test/src/test/java/org/apache/cxf/tools/wsdlto/jaxws/CodeGenTest.java
URL: http://svn.apache.org/viewvc/cxf/trunk/tools/wsdlto/test/src/test/java/org/apache/cxf/tools/wsdlto/jaxws/CodeGenTest.java?rev=673548&r1=673547&r2=673548&view=diff
==============================================================================
--- cxf/trunk/tools/wsdlto/test/src/test/java/org/apache/cxf/tools/wsdlto/jaxws/CodeGenTest.java (original)
+++ cxf/trunk/tools/wsdlto/test/src/test/java/org/apache/cxf/tools/wsdlto/jaxws/CodeGenTest.java Wed Jul  2 16:34:15 2008
@@ -956,7 +956,6 @@
         assertNotNull("method should be generated", method);
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testSupportXMLBindingBare() throws Exception {
         env.put(ToolConstants.CFG_WSDLURL, getLocation("/wsdl2java_wsdl/xml_http_bare.wsdl"));