[GitHub] [apisix] leslie-tsang commented on pull request #9662: chore: add missing `report_interval` option for `skywalking` plugin in `config-default.yaml`

["leslie-tsang (via GitHub)" <gi...@apache.org>]

leslie-tsang commented on PR #9662:
URL: https://github.com/apache/apisix/pull/9662#issuecomment-1608870163

   > > I wonder if it is necessary to upload once every 1 second.
   > 
   > If this needs to be changed, maybe it could be in a different PR as it's somewhat of a functional change? This PR only adds the configuration option so that it's visible. It is 1 second by default and therefore isn't a functional change.
   
   Cloud u please tell me where this `1s` comes from?
   
   After reviewing the code, I found that it should actually be 3 seconds. Please correct me if I'm wrong.
   
   References:
   * https://github.com/apache/apisix/blob/b024f683ef6f5310a180cdb6f792365e4c78f33a/apisix/plugins/skywalking.lua#L44-L46
   * https://github.com/apache/apisix/blob/b024f683ef6f5310a180cdb6f792365e4c78f33a/apisix/plugins/skywalking.lua#L139C16-L139C33
   * https://github.com/apache/skywalking-nginx-lua/blob/d15c0ce8ac10a903efc1379bf19cbe48641f331b/lib/skywalking/client.lua#L25C41-L25C41


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org