[GitHub] rfscholte commented on a change in pull request #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#discussion_r160032052
 
 

 ##########
 File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
 ##########
 @@ -197,9 +197,18 @@
     @Component
     private RuntimeInformation rtInfo;
 
+    /**
+     * Path to {@code plugin.xml} plugin descriptor to generate the report from.
+     *
+     * @since 3.5.1
+     */
+    @Parameter( defaultValue = "${project.build.outputDirectory}/META-INF/maven/plugin.xml", required = true )
 
 Review comment:
   I would like to see this as a readOnly parameter. Changing its value will break things.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services