You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@airavata.apache.org by GitBox <gi...@apache.org> on 2020/04/29 22:15:59 UTC

[GitHub] [airavata-mft] gkiran292 opened a new pull request #13: Feature/ftp transport

gkiran292 opened a new pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13


   FTP transport changes.
   
   @DImuthuUpe Please review this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] gkiran292 commented on a change in pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
gkiran292 commented on a change in pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#discussion_r418701150



##########
File path: services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/entity/FTPStorageEntity.java
##########
@@ -0,0 +1,48 @@
+package org.apache.airavata.mft.resource.server.backend.sql.entity;

Review comment:
       Done! Pushed the changes!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] aniruddhavpatil commented on a change in pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
aniruddhavpatil commented on a change in pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#discussion_r419161778



##########
File path: services/secret-service/server/src/main/java/org/apache/airavata/mft/secret/server/backend/SecretBackend.java
##########
@@ -55,4 +55,9 @@
     public DropboxSecret createDropboxSecret(DropboxSecretCreateRequest request) throws Exception;
     public boolean updateDropboxSecret(DropboxSecretUpdateRequest request) throws Exception;
     public boolean deleteDropboxSecret(DropboxSecretDeleteRequest request) throws Exception;
+
+    Optional<FTPSecret> getFTPSecret(FTPSecretGetRequest request) throws Exception;

Review comment:
       @gkiran292 @DImuthuUpe 
   For keeping it uniform, I guess adding a public modifier to each of these declarations would be better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] dinukadesilva commented on a change in pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
dinukadesilva commented on a change in pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#discussion_r418398107



##########
File path: services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/SQLResourceBackend.java
##########
@@ -18,12 +18,8 @@
 package org.apache.airavata.mft.resource.server.backend.sql;
 
 import org.apache.airavata.mft.resource.server.backend.ResourceBackend;
-import org.apache.airavata.mft.resource.server.backend.sql.entity.LocalResourceEntity;
-import org.apache.airavata.mft.resource.server.backend.sql.entity.SCPResourceEntity;
-import org.apache.airavata.mft.resource.server.backend.sql.entity.SCPStorageEntity;
-import org.apache.airavata.mft.resource.server.backend.sql.repository.LocalResourceRepository;
-import org.apache.airavata.mft.resource.server.backend.sql.repository.SCPResourceRepository;
-import org.apache.airavata.mft.resource.server.backend.sql.repository.SCPStorageRepository;

Review comment:
       Good to have individual imports




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] gkiran292 commented on a change in pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
gkiran292 commented on a change in pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#discussion_r418685121



##########
File path: services/secret-service/server/src/main/resources/secrets.json
##########
@@ -32,5 +32,11 @@
     "type": "DROPBOX",
     "secretId": "dropbox-cred",
     "accessToken": ""
+  },
+  {
+    "type": "FTP",

Review comment:
       This is the generic username and password for testing. The website https://dlptest.com/ftp-test/ offers an FTP server for testing purposes. The files remain for 30 mins from the time of upload. I left for testing purposes. Since it's publicly available should I remove it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] sharanya17410 edited a comment on pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
sharanya17410 edited a comment on pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#issuecomment-622163825


   You have missed including the dependency for your FTP-transport under mft-agent/pom.xml


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] gkiran292 commented on pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
gkiran292 commented on pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#issuecomment-622173427


   > You have missed including the dependency for your FTP-transport under mft-agent/pom.xml
   
   I have added it!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] sharanya17410 commented on pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
sharanya17410 commented on pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#issuecomment-622163825


   You have missed including your FTP-transport under mft-agent/pom.xml


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] gkiran292 commented on a change in pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
gkiran292 commented on a change in pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#discussion_r418701242



##########
File path: services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/entity/FTPResourceEntity.java
##########
@@ -0,0 +1,57 @@
+package org.apache.airavata.mft.resource.server.backend.sql.entity;

Review comment:
       Done! Pushed the changes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] gkiran292 commented on a change in pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
gkiran292 commented on a change in pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#discussion_r418685497



##########
File path: services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/entity/FTPStorageEntity.java
##########
@@ -0,0 +1,48 @@
+package org.apache.airavata.mft.resource.server.backend.sql.entity;

Review comment:
       Agreed! I will add the license headers

##########
File path: services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/entity/FTPResourceEntity.java
##########
@@ -0,0 +1,57 @@
+package org.apache.airavata.mft.resource.server.backend.sql.entity;

Review comment:
       Agreed! I will add the license headers




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] gkiran292 commented on a change in pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
gkiran292 commented on a change in pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#discussion_r418686698



##########
File path: services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/SQLResourceBackend.java
##########
@@ -18,12 +18,8 @@
 package org.apache.airavata.mft.resource.server.backend.sql;
 
 import org.apache.airavata.mft.resource.server.backend.ResourceBackend;
-import org.apache.airavata.mft.resource.server.backend.sql.entity.LocalResourceEntity;
-import org.apache.airavata.mft.resource.server.backend.sql.entity.SCPResourceEntity;
-import org.apache.airavata.mft.resource.server.backend.sql.entity.SCPStorageEntity;
-import org.apache.airavata.mft.resource.server.backend.sql.repository.LocalResourceRepository;
-import org.apache.airavata.mft.resource.server.backend.sql.repository.SCPResourceRepository;
-import org.apache.airavata.mft.resource.server.backend.sql.repository.SCPStorageRepository;

Review comment:
       Accepted! I will push the new changes with individual imports!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] DImuthuUpe commented on a change in pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
DImuthuUpe commented on a change in pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#discussion_r418654882



##########
File path: services/secret-service/server/src/main/resources/secrets.json
##########
@@ -32,5 +32,11 @@
     "type": "DROPBOX",
     "secretId": "dropbox-cred",
     "accessToken": ""
+  },
+  {
+    "type": "FTP",

Review comment:
       Remove passwords and specific user ids. Make them generic as possible

##########
File path: services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/entity/FTPStorageEntity.java
##########
@@ -0,0 +1,48 @@
+package org.apache.airavata.mft.resource.server.backend.sql.entity;

Review comment:
       License headers?

##########
File path: services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/entity/FTPResourceEntity.java
##########
@@ -0,0 +1,57 @@
+package org.apache.airavata.mft.resource.server.backend.sql.entity;

Review comment:
       License headers?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] gkiran292 commented on a change in pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
gkiran292 commented on a change in pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#discussion_r418701042



##########
File path: services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/SQLResourceBackend.java
##########
@@ -18,12 +18,8 @@
 package org.apache.airavata.mft.resource.server.backend.sql;
 
 import org.apache.airavata.mft.resource.server.backend.ResourceBackend;
-import org.apache.airavata.mft.resource.server.backend.sql.entity.LocalResourceEntity;
-import org.apache.airavata.mft.resource.server.backend.sql.entity.SCPResourceEntity;
-import org.apache.airavata.mft.resource.server.backend.sql.entity.SCPStorageEntity;
-import org.apache.airavata.mft.resource.server.backend.sql.repository.LocalResourceRepository;
-import org.apache.airavata.mft.resource.server.backend.sql.repository.SCPResourceRepository;
-import org.apache.airavata.mft.resource.server.backend.sql.repository.SCPStorageRepository;

Review comment:
       Done I have pushed the changes. Please review it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata-mft] DImuthuUpe commented on pull request #13: Feature/ftp transport - FTP Transport protocol PR

Posted by GitBox <gi...@apache.org>.
DImuthuUpe commented on pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#issuecomment-623162403


   Looks good to me. Great work. Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org