You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/09/08 05:38:36 UTC

[GitHub] [commons-collections] garydgregory commented on a change in pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

garydgregory commented on a change in pull request #250:
URL: https://github.com/apache/commons-collections/pull/250#discussion_r704062226



##########
File path: src/test/java/org/apache/commons/collections4/set/UnmodifiableNavigableSetTest.java
##########
@@ -143,6 +143,23 @@ public void verifyUnmodifiable(final Set<E> set) {
         } catch (final UnsupportedOperationException e) {
             // expected
         }
+
+        if (set instanceof NavigableSet) {
+            final NavigableSet<E> navigableSet = (NavigableSet<E>) set;
+
+            try {

Review comment:
       Too verbose, use assertThrows().




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org