You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/04 13:53:03 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #1993: Migrate ServiceNow, Slack, Geocoder & Telegram tests to WireMock
jamesnetherton opened a new pull request #1993:
URL: https://github.com/apache/camel-quarkus/pull/1993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1993: Migrate ServiceNow, Slack, Geocoder & Telegram tests to WireMock
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1993:
URL: https://github.com/apache/camel-quarkus/pull/1993#discussion_r517363240
##########
File path: extensions/geocoder/deployment/src/main/java/org/apache/camel/quarkus/component/geocoder/deployment/GeocoderProcessor.java
##########
@@ -50,6 +50,7 @@ ExtensionSslNativeSupportBuildItem activateSslNativeSupport() {
items.add(new ReflectiveClassBuildItem(false, true, "com.google.maps.model.Bounds"));
items.add(new ReflectiveClassBuildItem(false, true, "com.google.maps.model.LatLng"));
items.add(new ReflectiveClassBuildItem(false, true, "com.google.maps.model.LocationType"));
+ items.add(new ReflectiveClassBuildItem(false, true, "com.google.maps.model.GeolocationPayload"));
Review comment:
Your effort pays back!
##########
File path: integration-tests/telegram/pom.xml
##########
@@ -56,17 +56,18 @@
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-attachments</artifactId>
</dependency>
- <dependency>
- <groupId>org.apache.camel.quarkus</groupId>
- <artifactId>camel-quarkus-integration-test-support-mock-backend</artifactId>
- </dependency>
Review comment:
The auditing idea was based on the assumption that the number of <artifactId>camel-quarkus-integration-test-support-mock-backend</artifactId> occurrences in poms must be equal to the number of the magic log tokens. Now we are stopping to use <artifactId>camel-quarkus-integration-test-support-mock-backend</artifactId> .
Yes, <artifactId>camel-quarkus-integration-wiremock-support</artifactId> is a replacement, but probably not all mock will be HTTP, so the interested parties (cc @llowinge ) will have to add the number of <artifactId>camel-quarkus-integration-wiremock-support</artifactId> occurrences to the number of <artifactId>camel-quarkus-integration-test-support-mock-backend</artifactId>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #1993: Migrate ServiceNow, Slack, Geocoder & Telegram tests to WireMock
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1993:
URL: https://github.com/apache/camel-quarkus/pull/1993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1993: Migrate ServiceNow, Slack, Geocoder & Telegram tests to WireMock
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1993:
URL: https://github.com/apache/camel-quarkus/pull/1993#discussion_r517380135
##########
File path: integration-tests/telegram/pom.xml
##########
@@ -56,17 +56,18 @@
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-attachments</artifactId>
</dependency>
- <dependency>
- <groupId>org.apache.camel.quarkus</groupId>
- <artifactId>camel-quarkus-integration-test-support-mock-backend</artifactId>
- </dependency>
Review comment:
Let me think about this some more because there are probably other (better) ways of achieving this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org