You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/10 19:00:23 UTC
[GitHub] codecov-io edited a comment on issue #4981: Make time filter more
usable
codecov-io edited a comment on issue #4981: Make time filter more usable
URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-388507979
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr&el=h1) Report
> Merging [#4981](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6b15592dd0b916fe4394a3759f254bffb7895abe?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `67.21%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4981/graphs/tree.svg?width=650&src=pr&token=KsB0fHcx6l&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4981 +/- ##
==========================================
- Coverage 61.31% 61.15% -0.16%
==========================================
Files 369 369
Lines 23497 23566 +69
Branches 2715 2724 +9
==========================================
+ Hits 14407 14412 +5
- Misses 9078 9140 +62
- Partials 12 14 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set/assets/src/dashboard/deprecated/v1/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvZGVwcmVjYXRlZC92MS9yZWR1Y2Vycy5qcw==) | `0% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/explore/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3Zpc1R5cGVzLmpz) | `55.55% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `47.32% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/filter\_box.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9maWx0ZXJfYm94LmpzeA==) | `27.27% <0%> (+0.24%)` | :arrow_up: |
| [superset/legacy.py](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | `18.3% <100%> (+3.6%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.11% <100%> (+0.25%)` | :arrow_up: |
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.78% <100%> (+0.97%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `77.95% <100%> (-3.4%)` | :arrow_down: |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvRGF0ZUZpbHRlckNvbnRyb2wuanN4) | `58.41% <50%> (-9.33%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr&el=footer). Last update [6b15592...128db9f](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org