You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/11 12:05:58 UTC
[GitHub] [apisix-dashboard] okaybase opened a new pull request #2168: fix: select Use the domain or IP from Node List
okaybase opened a new pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
When create Upstream and select `Use the domain or IP from Node List`, tips:
**Related issues**
fix/resolve:
PR(2118) change `name="nodes"` to `name="submitNodes"`, so this PR sync the change in file PassHost.tsx
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-939986635
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2168](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (975dd22) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a8298f40038b9488e9c177af273025cff3990a1b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8298f4) will **decrease** coverage by `1.13%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2168 +/- ##
==========================================
- Coverage 69.34% 68.21% -1.14%
==========================================
Files 188 127 -61
Lines 7161 3347 -3814
Branches 823 823
==========================================
- Hits 4966 2283 -2683
+ Misses 1906 1064 -842
+ Partials 289 0 -289
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `68.21% <0.00%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eb/src/components/Upstream/components/PassHost.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvUGFzc0hvc3QudHN4) | `75.00% <0.00%> (ø)` | |
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | |
| [api/cmd/status.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdGF0dXMuZ28=) | | |
| [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | |
| [api/cmd/stop.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdG9wLmdv) | | |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | | |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | | |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | |
| ... and [53 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a8298f4...975dd22](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] okaybase commented on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
okaybase commented on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-942938425
> > @bzp2010 You are right, after testing, the case(delete the only node then submit) also exists problem, i will fix it together.
>
> @okaybase Nice jobs!
>
> BTW, I found a issue maybe about it. #2155 Can you take a look?
@bzp2010 Confirmed, same problem, this PR will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] okaybase edited a comment on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
okaybase edited a comment on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-942938425
> > @bzp2010 You are right, after testing, the case(delete the only node then submit) also exists problem, i will fix it together.
>
> @okaybase Nice jobs!
>
> BTW, I found a issue maybe about it. #2155 Can you take a look?
@bzp2010 Confirmed, they are same problem, this PR will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 edited a comment on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
bzp2010 edited a comment on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-941929888
Hi, @okaybase. Thank you for your contribution.
After testing, I found some problems.
1. First I make this settings.
2. Then I delete the only node.
3. Despite some problems with the data, I can still submit and move on to the next step.
4. However, the data is still pass, which leads to data inconsistency.
#### Please test it to confirm whether there is this problem. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] okaybase removed a comment on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
okaybase removed a comment on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-941960569
@bzp2010 You are right, after testing, the case(delete the only node then submit) also exists problem, i will fix it together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] okaybase commented on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
okaybase commented on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-944445977
@bzp2010 after confirm and testing again, maybe the current logic for your test case is reasonable.
see the doc description: https://github.com/apache/apisix/blob/master/docs/en/latest/admin-api.md#upstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] okaybase removed a comment on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
okaybase removed a comment on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-942938425
> > @bzp2010 You are right, after testing, the case(delete the only node then submit) also exists problem, i will fix it together.
>
> @okaybase Nice jobs!
>
> BTW, I found a issue maybe about it. #2155 Can you take a look?
@bzp2010 Confirmed, they are same problem, this PR will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran merged pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
liuxiran merged pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-941929888
Hi, @okaybase. Thank you for your contribution.
After testing, I found some problems.
1. First I make this settings.
2. Then I delete the only node.
3. Despite some problems with the data, I can still submit and move on to the next step.
4. However, the data is still pass, which leads to data inconsistency.
#### Please test it to confirm whether there is this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-939986635
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2168](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33134e2) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a8298f40038b9488e9c177af273025cff3990a1b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8298f4) will **decrease** coverage by `1.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2168 +/- ##
==========================================
- Coverage 69.34% 68.24% -1.11%
==========================================
Files 188 127 -61
Lines 7161 3347 -3814
Branches 823 823
==========================================
- Hits 4966 2284 -2682
+ Misses 1906 1063 -843
+ Partials 289 0 -289
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `68.24% <100.00%> (+0.08%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eb/src/components/Upstream/components/PassHost.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvUGFzc0hvc3QudHN4) | `81.25% <100.00%> (+6.25%)` | :arrow_up: |
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | |
| [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | | |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | |
| [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | | |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | |
| [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | | |
| [api/cmd/root.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9yb290Lmdv) | | |
| ... and [53 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2168/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a8298f4...33134e2](https://codecov.io/gh/apache/apisix-dashboard/pull/2168?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-942483365
> @bzp2010 You are right, after testing, the case(delete the only node then submit) also exists problem, i will fix it together.
Nice jobs!
BTW, I found a issue maybe about it. #2155 Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-941929888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] okaybase commented on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
okaybase commented on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-941960569
@bzp2010 You are right, after testing, the case(delete the only node then submit) also exists problem, i will fix it together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 edited a comment on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
bzp2010 edited a comment on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-941929888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] okaybase commented on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
okaybase commented on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-941960569
@bzp2010 You are right, after testing, the case(delete the only node then submit) also exists problem, i will fix it together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#discussion_r727021306
##########
File path: web/src/components/Upstream/components/PassHost.tsx
##########
@@ -87,7 +87,7 @@ const Component: React.FC<Props> = ({ form, readonly }) => {
if (
form.getFieldValue('pass_host') === 'node' &&
- (form.getFieldValue('nodes') || []).length !== 1
+ (form.getFieldValue('submitNodes') || []).length !== 1
Review comment:
need @bzp2010's confirmation 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 edited a comment on pull request #2168: fix: select Use the domain or IP from Node List
Posted by GitBox <gi...@apache.org>.
bzp2010 edited a comment on pull request #2168:
URL: https://github.com/apache/apisix-dashboard/pull/2168#issuecomment-942483365
> @bzp2010 You are right, after testing, the case(delete the only node then submit) also exists problem, i will fix it together.
@okaybase Nice jobs!
BTW, I found a issue maybe about it. #2155 Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org