You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2013/05/24 16:00:29 UTC

svn commit: r1486056 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractInputBuffer.java InternalAprInputBuffer.java InternalNioInputBuffer.java

Author: markt
Date: Fri May 24 14:00:29 2013
New Revision: 1486056

URL: http://svn.apache.org/r1486056
Log:
Improve Javadoc

Modified:
    tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java
    tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java
    tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java?rev=1486056&r1=1486055&r2=1486056&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java Fri May 24 14:00:29 2013
@@ -232,6 +232,12 @@ public abstract class AbstractInputBuffe
 
     public abstract boolean parseHeaders() throws IOException;
 
+    /**
+     * Attempts to read some data into the input buffer.
+     *
+     * @return <code>true</code> if more data was added to the input buffer
+     *         otherwise <code>false</code>
+     */
     protected abstract boolean fill(boolean block) throws IOException;
 
     protected abstract void init(SocketWrapper<S> socketWrapper,

Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java?rev=1486056&r1=1486055&r2=1486056&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java Fri May 24 14:00:29 2013
@@ -554,12 +554,6 @@ public class InternalAprInputBuffer exte
     }
 
 
-    /**
-     * Attempts to read some data into the input buffer.
-     *
-     * @return <code>true</code> if more data was added to the input buffer
-     *         otherwise <code>false</code>
-     */
     @Override
     protected boolean fill(boolean block) throws IOException {
         // Ignore the block parameter

Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java?rev=1486056&r1=1486055&r2=1486056&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java Fri May 24 14:00:29 2013
@@ -796,18 +796,14 @@ public class InternalNioInputBuffer exte
     }
 
 
-    /**
-     * Fill the internal buffer using data from the underlying input stream.
-     *
-     * @return false if at end of stream
-     */
     @Override
     protected boolean fill(boolean block) throws IOException, EOFException {
         return fill(true,block);
     }
 
-    protected boolean fill(boolean timeout, boolean block) throws IOException, EOFException {
 
+    protected boolean fill(boolean timeout, boolean block)
+            throws IOException, EOFException {
 
         boolean read = false;
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org