[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3810: Make expression manipulation consistent and easier to use: `combine/split filter` `conjunction`, etc

[GitBox <gi...@apache.org>]

alamb commented on code in PR #3810:
URL: https://github.com/apache/arrow-datafusion/pull/3810#discussion_r996289143


##########
datafusion/optimizer/src/utils.rs:
##########
@@ -424,31 +468,74 @@ mod tests {
     use super::*;
     use arrow::datatypes::DataType;
     use datafusion_common::Column;
-    use datafusion_expr::{binary_expr, col, lit, utils::expr_to_columns};
+    use datafusion_expr::{col, lit, utils::expr_to_columns};
     use std::collections::HashSet;
     use std::ops::Add;
 
     #[test]
-    fn combine_zero_filters() {
-        let result = combine_filters(&[]);
-        assert_eq!(result, None);
+    fn test_split_conjunction() {

Review Comment:
   This was a great idea @jackwener  -- thank you. I added this test  09f3cf4e4
   
   As part of writing tests, I also found that the API for `disjunction` was slightly different than `conjunction` so I made them the same as well. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org