You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/08 15:28:26 UTC
[GitHub] [flink-training] alpinegizmo opened a new pull request #12: [FLINK-18499] Update for Flink 1.11: don’t use deprecated forms of keyBy
alpinegizmo opened a new pull request #12:
URL: https://github.com/apache/flink-training/pull/12
Clean-up the keyBys for Flink 1.11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-training] alpinegizmo commented on a change in pull request #12: [FLINK-18499] Update for Flink 1.11: don’t use deprecated forms of keyBy
Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on a change in pull request #12:
URL: https://github.com/apache/flink-training/pull/12#discussion_r452161254
##########
File path: long-ride-alerts/src/main/java/org/apache/flink/training/exercises/longrides/LongRidesExercise.java
##########
@@ -67,7 +67,7 @@ public static void main(String[] args) throws Exception {
DataStream<TaxiRide> rides = env.addSource(rideSourceOrTest(new TaxiRideSource(input, maxEventDelay, servingSpeedFactor)));
DataStream<TaxiRide> longRides = rides
- .keyBy(ride -> ride.rideId)
+ .keyBy((TaxiRide ride) -> ride.rideId)
Review comment:
That's right. It's not necessary, I just added it for clarity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-training] afedulov commented on a change in pull request #12: [FLINK-18499] Update for Flink 1.11: don’t use deprecated forms of keyBy
Posted by GitBox <gi...@apache.org>.
afedulov commented on a change in pull request #12:
URL: https://github.com/apache/flink-training/pull/12#discussion_r452147867
##########
File path: long-ride-alerts/src/main/java/org/apache/flink/training/exercises/longrides/LongRidesExercise.java
##########
@@ -67,7 +67,7 @@ public static void main(String[] args) throws Exception {
DataStream<TaxiRide> rides = env.addSource(rideSourceOrTest(new TaxiRideSource(input, maxEventDelay, servingSpeedFactor)));
DataStream<TaxiRide> longRides = rides
- .keyBy(ride -> ride.rideId)
+ .keyBy((TaxiRide ride) -> ride.rideId)
Review comment:
I believe that this type definition is not strictly necessary. Is it added to make it easier for comprehension?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-training] sjwiesman closed pull request #12: [FLINK-18499] Update for Flink 1.11: don’t use deprecated forms of keyBy
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #12:
URL: https://github.com/apache/flink-training/pull/12
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org