You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "mingdaoy (via GitHub)" <gi...@apache.org> on 2025/02/19 19:49:07 UTC

[PR] KAFKA-18834 Fix testSetLevelWithValidRootLoggerNames for testSetLevel… [kafka]

mingdaoy opened a new pull request, #18972:
URL: https://github.com/apache/kafka/pull/18972

   https://issues.apache.org/jira/browse/KAFKA-18834
   
   ```
   ./gradlew cleanTest connect:runtime:test --tests LoggersTest.testSetLevelWithValidRootLoggerNames --tests LoggingResourceTest.testSetLevelDefaultScope -PmaxParallelForks=1
   ```
   ![image](https://github.com/user-attachments/assets/c1d030bd-0b63-4055-96d6-742f57e723f4)
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-18834 Fix LoggingResourceTest#testSetLevelDefaultScope [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.

chia7712 commented on PR #18972:
URL: https://github.com/apache/kafka/pull/18972#issuecomment-2669973567

   Another way is to reset the log level in `testSetLevelWithValidRootLoggerNames`. It changes "all" loggers, so it may impact other tests too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-18834 Fix LoggingResourceTest#testSetLevelDefaultScope [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.

chia7712 commented on PR #18972:
URL: https://github.com/apache/kafka/pull/18972#issuecomment-2669837799

   Personally, I prefer to adjust the level for the testSetLevelDefaultScope. Please see my comment on the jira


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-18834 Fix LoggingResourceTest#testSetLevelDefaultScope [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.

chia7712 commented on code in PR #18972:
URL: https://github.com/apache/kafka/pull/18972#discussion_r1962485553


##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResourceTest.java:
##########
@@ -113,7 +113,7 @@ public void setLevelWithInvalidArgTest() {
 
     @Test
     public void testSetLevelDefaultScope() {
-        testSetLevelWorkerScope(null, true);
+        testSetLevelWorkerScope("worker", false);

Review Comment:
   Sorry that I fail to catch this fix. Could you please share the detail to me?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-18834 Fix LoggingResourceTest#testSetLevelDefaultScope [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #18972:
URL: https://github.com/apache/kafka/pull/18972#issuecomment-3006945112

   This PR is being marked as stale since it has not had any activity in 90 days. If you
   would like to keep this PR alive, please leave a comment asking for a review. If the PR has 
   merge conflicts, update it with the latest from the base branch.
   <p>
   If you are having difficulty finding a reviewer, please reach out on the 
   [mailing list](https://kafka.apache.org/contact).
   <p>
   If this PR is no longer valid or desired, please feel free to close it. If no activity
   occurs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-18834 Fix testSetLevelWithValidRootLoggerNames for testSetLevel… [kafka]

Posted by "mingdaoy (via GitHub)" <gi...@apache.org>.

mingdaoy commented on PR #18972:
URL: https://github.com/apache/kafka/pull/18972#issuecomment-2669615037

   Hi maintainers, could you please approve this workflow when you have a chance? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org