[GitHub] [shardingsphere] jiangML opened a new issue, #21067: Refactor the agent configuration file

[GitBox <gi...@apache.org>]

jiangML opened a new issue, #21067:
URL: https://github.com/apache/shardingsphere/issues/21067

   ## Feature Request
   
   ### Is your feature request related to a problem?
    no 
   ### Describe the feature you would like.
   
   1. The agent configuration file does not correspond to the module structure.
   2. 'ignoredPluginNames' is difficult for users to understand.
   
   #### Current agent.yml
   ```
   applicationName: shardingsphere
   ignoredPluginNames:
     - Jaeger
     - OpenTracing
     - Zipkin
     - OpenTelemetry
     - Logging
     - Prometheus
   
   plugins:
     Prometheus:
       host:  "localhost"
       port: 9090
       props:
         JVM_INFORMATION_COLLECTOR_ENABLED : "true"
     Jaeger:
       host: "localhost"
       port: 5775
       props:
         SERVICE_NAME: "shardingsphere"
         JAEGER_SAMPLER_TYPE: "const"
         JAEGER_SAMPLER_PARAM: "1"
     Zipkin:
       host: "localhost"
       port: 9411
       props:
         SERVICE_NAME: "shardingsphere"
         URL_VERSION: "/api/v2/spans"
         SAMPLER_TYPE: "const"
         SAMPLER_PARAM: "1"
     OpenTracing:
       props:
         OPENTRACING_TRACER_CLASS_NAME: "org.apache.skywalking.apm.toolkit.opentracing.SkywalkingTracer"
     OpenTelemetry:
       props:
         otel.resource.attributes: "service.name=shardingsphere"
         otel.traces.exporter: "zipkin"
     Logging:
       props:
         LEVEL: "INFO"
   
   ```
   
   ####  Expected agent.yml
   ```
   plugins:
       Logging:
         BaseLogging:
           props:
             xxx-xxx: xxx
       Metrics:
         Prometheus:
           host: "0.0.0.0"
           port: 9090
           props:
             xxx: xxx
       Tracing:
         Jaeger:
           host: "0.0.0.0"
           port: 5775
           props:
             xxx-xxx: xxx
         Zipkin:
           host: "0.0.0.0"
           port: 9411
           props:
             xxx-xxx: xxx
         OpenTracing:
           props:
             xxx-xxx: xxx
         OpenTelemetry:
           props:
             xxx-xxx: xxx
   ```
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang closed issue #21067: Refactor the agent configuration file

[GitBox <gi...@apache.org>]

RaigorJiang closed issue #21067: Refactor the agent configuration file
URL: https://github.com/apache/shardingsphere/issues/21067


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #21067: Refactor the agent configuration file

[GitBox <gi...@apache.org>]

RaigorJiang commented on issue #21067:
URL: https://github.com/apache/shardingsphere/issues/21067#issuecomment-1250780595

   Good suggestion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org