You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/07/24 23:24:15 UTC
Review Request 36794: Handle potential 'net::hostname()' failure.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36794/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-3145
https://issues.apache.org/jira/browse/MESOS-3145
Repository: mesos
Description
-------
See summary
Diffs
-----
include/mesos/mesos.proto e015c81d5052214ef8207642e23b3892a6123c9a
src/sched/sched.cpp e411f376938a2c6793621de42e60425e5faed453
Diff: https://reviews.apache.org/r/36794/diff/
Testing
-------
`make check` + successfully ran the following test:
```
$ sudo hostname foo # an unresolvable hostname
$ sudo ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
$ LIBPROCESS_IP=127.0.0.1 ./src/mesos-execute --master=127.0.0.1:5050 --name=bar --command="while true; do sleep 100; done"
```
Thanks,
Michael Park
Re: Review Request 36794: Handle potential 'net::hostname()' failure.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36794/#review92986
-----------------------------------------------------------
Ship it!
Committing, thanks MPark!
src/sched/sched.cpp (line 1526)
<https://reviews.apache.org/r/36794/#comment147262>
s/result/hostname/?
- Benjamin Hindman
On July 24, 2015, 9:24 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36794/
> -----------------------------------------------------------
>
> (Updated July 24, 2015, 9:24 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-3145
> https://issues.apache.org/jira/browse/MESOS-3145
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e015c81d5052214ef8207642e23b3892a6123c9a
> src/sched/sched.cpp e411f376938a2c6793621de42e60425e5faed453
>
> Diff: https://reviews.apache.org/r/36794/diff/
>
>
> Testing
> -------
>
> `make check` + successfully ran the following test:
>
> ```
> $ sudo hostname foo # an unresolvable hostname
> $ sudo ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
> $ LIBPROCESS_IP=127.0.0.1 ./src/mesos-execute --master=127.0.0.1:5050 --name=bar --command="while true; do sleep 100; done"
> ```
>
>
> Thanks,
>
> Michael Park
>
>