You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@camel.apache.org by "Dixon Whitmire (Jira)" <ji...@apache.org> on 2020/06/16 02:21:00 UTC

[jira] [Comment Edited] (CAMEL-15184) PackageScan.findImplementation - Should filter out abstract classes

    [ https://issues.apache.org/jira/browse/CAMEL-15184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136239#comment-17136239 ] 

Dixon Whitmire edited comment on CAMEL-15184 at 6/16/20, 2:20 AM:
------------------------------------------------------------------

The [findImplementation|https://github.com/apache/camel/blob/master/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultPackageScanClassResolver.java#L117] method uses a predicate/filter, [AssignableToPackageScanFilter|https://github.com/apache/camel/blob/master/core/camel-base/src/main/java/org/apache/camel/impl/scan/AssignableToPackageScanFilter.java#L46],  to find matching classes. It seems that it would be ideal to add an additional filter, isConcreteClass, and update findImplementation to utilize both filters, AssignableToPackageScanFilter and isConcreteClass, using [getCompositeFilter|https://github.com/apache/camel/blob/master/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultPackageScanClassResolver.java#L271].

From what I can tell, this approach leaves the AssignableToPackageScanFilter intact so that it may be utilized within Spring/Spring Boot without issue.


was (Author: dixonwh):
The [findImplementation|https://github.com/apache/camel/blob/master/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultPackageScanClassResolver.java#L117] method uses a predicate/filter, [AssignableToPackageScanFilter|https://github.com/apache/camel/blob/master/core/camel-base/src/main/java/org/apache/camel/impl/scan/AssignableToPackageScanFilter.java#L46],  to find matching classes. It seems that it would be ideal to add an additional filter, isConcreteClass, and update findImplementation to utilize both filters, AssignableToPackageScanFilter and isConcreteClass, using [getCompositeFilter|https://github.com/apache/camel/blob/master/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultPackageScanClassResolver.java#L271].

> PackageScan.findImplementation - Should filter out abstract classes
> -------------------------------------------------------------------
>
>                 Key: CAMEL-15184
>                 URL: https://issues.apache.org/jira/browse/CAMEL-15184
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 3.4.0
>            Reporter: Claus Ibsen
>            Priority: Major
>             Fix For: 3.5.0
>
>
> See CAMEL-15813 and the Pr
> https://github.com/apache/camel/pull/3911



--
This message was sent by Atlassian Jira
(v8.3.4#803005)