You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/18 10:08:25 UTC

[GitHub] [airflow] realradical edited a comment on pull request #8875: [AIRFLOW-8875] fix Dag Run UI execution date with timezone cannot be saved issue

realradical edited a comment on pull request #8875:
URL: https://github.com/apache/airflow/pull/8875#issuecomment-630081091


   > @conf_vars
   
   @ashb I tried changing the timezone in the UI and it works!
   
   I used `@conf_vars({("core", "default_timezone"): "America/Toronto"})` in the test without timezone. However, the timezone setting used in `timezone.make_aware` utility function is initialized before the config overriding in my test. https://github.com/apache/airflow/blob/master/airflow/settings.py
   
   Personally I don't think we need to cover this case, the frontend should make sure that the datetime submitted always with a timezone. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org